Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 75113003: Refactor GraphicsLayer::setContentsToImage(). (Closed)

Created:
7 years, 1 month ago by dshwang
Modified:
7 years, 1 month ago
Reviewers:
danakj, jamesr
CC:
blink-reviews, jamesr, krit, danakj, dsinclair, blink-layers+watch_chromium.org, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Refactor GraphicsLayer::setContentsToImage(). This has three parts: 1) setContentsToImage() uses setContentsTo() like setContentsToNinePatch(), setContentsToCanvas(), and setContentsToMedia(). 2) get rid of duplicated code to setContentsTo() in setContentsToImage(). 3) remove unused ContentsLayerPurpose enum. BUG=114658 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162541

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -29 lines) Patch
M Source/core/platform/graphics/GraphicsLayer.h View 3 chunks +1 line, -11 lines 0 comments Download
M Source/core/platform/graphics/GraphicsLayer.cpp View 5 chunks +6 lines, -18 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
dshwang
7 years, 1 month ago (2013-11-19 16:16:01 UTC) #1
jamesr
lgtm https://codereview.chromium.org/75113003/diff/1/Source/core/platform/graphics/GraphicsLayer.cpp File Source/core/platform/graphics/GraphicsLayer.cpp (right): https://codereview.chromium.org/75113003/diff/1/Source/core/platform/graphics/GraphicsLayer.cpp#newcode1008 Source/core/platform/graphics/GraphicsLayer.cpp:1008: void GraphicsLayer::setContentsToCanvas(WebLayer* layer) i assume you'll remove these ...
7 years, 1 month ago (2013-11-21 20:46:02 UTC) #2
dshwang
On 2013/11/21 20:46:02, jamesr wrote: > lgtm Thank you for review. > https://codereview.chromium.org/75113003/diff/1/Source/core/platform/graphics/GraphicsLayer.cpp > File ...
7 years, 1 month ago (2013-11-22 11:41:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/75113003/1
7 years, 1 month ago (2013-11-22 11:41:17 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 13:07:10 UTC) #5
Message was sent while issue was closed.
Change committed as 162541

Powered by Google App Engine
This is Rietveld 408576698