Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 7511001: Don't transition to in-session mode until the connection has been established. (Closed)

Created:
9 years, 5 months ago by Jamie
Modified:
9 years, 4 months ago
Reviewers:
awong, garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Don't transition to in-session mode until the connection has been established. BUG=83648 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94164

Patch Set 1 #

Total comments: 10

Patch Set 2 : Added comments from ajwong. #

Patch Set 3 : Changed client state callback to be passed the old state instead of the new one. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M remoting/webapp/me2mom/choice.html View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/me2mom/client_session.js View 1 2 3 3 chunks +7 lines, -2 lines 0 comments Download
M remoting/webapp/me2mom/remoting.js View 1 2 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Jamie
This causes errors in the access code to be reported, even if they're in the ...
9 years, 5 months ago (2011-07-25 23:09:50 UTC) #1
awong
http://codereview.chromium.org/7511001/diff/1/remoting/webapp/me2mom/choice.html File remoting/webapp/me2mom/choice.html (right): http://codereview.chromium.org/7511001/diff/1/remoting/webapp/me2mom/choice.html#newcode242 remoting/webapp/me2mom/choice.html:242: <section id="session-mode" class="mode in-session-element client-element"> On 2011/07/25 23:09:50, Jamie ...
9 years, 4 months ago (2011-07-26 18:51:27 UTC) #2
Jamie
http://codereview.chromium.org/7511001/diff/1/remoting/webapp/me2mom/choice.html File remoting/webapp/me2mom/choice.html (right): http://codereview.chromium.org/7511001/diff/1/remoting/webapp/me2mom/choice.html#newcode242 remoting/webapp/me2mom/choice.html:242: <section id="session-mode" class="mode in-session-element client-element"> On 2011/07/26 18:51:27, awong ...
9 years, 4 months ago (2011-07-26 19:02:34 UTC) #3
awong
On Tue, Jul 26, 2011 at 12:02 PM, <jamiewalch@chromium.org> wrote: > > http://codereview.chromium.**org/7511001/diff/1/remoting/** > webapp/me2mom/choice.html<http://codereview.chromium.org/7511001/diff/1/remoting/webapp/me2mom/choice.html> ...
9 years, 4 months ago (2011-07-26 19:08:11 UTC) #4
Jamie
> > Yes, that's generally my preference too, but if the callbacks needs both > ...
9 years, 4 months ago (2011-07-26 19:54:28 UTC) #5
garykac
9 years, 4 months ago (2011-07-26 21:11:05 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698