Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 751063008: Fix mouse cursor during drag and drop after HTML 5 pointer lock on Desktop Linux (Closed)

Created:
6 years ago by pkotwicz
Modified:
6 years ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix mouse cursor during drag and drop after HTML 5 pointer lock on Desktop Linux The return value of DesktopNativeCursorManager::GetInitializedCursor() is no longer valid after DesktopNativeCursorManager::SetDisplay() is called. This CL ensures that the return value of DesktopNativeCursorManager::GetInitializedCursor() is not cached. BUG=440534 TEST=Manual, see bug Committed: https://crrev.com/47448ead07db2523f29a55a99a6a1fd0b7a29f2a Cr-Commit-Position: refs/heads/master@{#308003}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.h View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_cursor_manager.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
pkotwicz
Sadrul, PTAL I found this bug because it was causing a crash in a test ...
6 years ago (2014-12-10 16:03:18 UTC) #3
sadrul
lgtm
6 years ago (2014-12-11 14:48:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751063008/20001
6 years ago (2014-12-11 15:54:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/17216)
6 years ago (2014-12-11 17:50:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/751063008/20001
6 years ago (2014-12-11 23:08:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years ago (2014-12-12 00:12:29 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-12 00:14:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47448ead07db2523f29a55a99a6a1fd0b7a29f2a
Cr-Commit-Position: refs/heads/master@{#308003}

Powered by Google App Engine
This is Rietveld 408576698