build/android/pylib/utils/md5sum.py - Issue 751063002: Allow RunShellCommand to work even with very large commands

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/utils/md5sum.py

Issue 751063002: Allow RunShellCommand to work even with very large commands (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comment implementation of WriteFile Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/utils/md5sum.py

diff --git a/build/android/pylib/utils/md5sum.py b/build/android/pylib/utils/md5sum.py

index 8c10bb0b88eb85d4e59a8832c5a22270b605b1b8..4d0d7038be4ae5602cd822bb66118a0de4390031 100644

--- a/build/android/pylib/utils/md5sum.py

+++ b/build/android/pylib/utils/md5sum.py

@@ -57,7 +57,8 @@ def CalculateDeviceMd5Sums(paths, device):

out = []

with tempfile.NamedTemporaryFile() as md5sum_script_file:

- with device_temp_file.DeviceTempFile(device) as md5sum_device_script_file:

+ with device_temp_file.DeviceTempFile(

+ device.adb) as md5sum_device_script_file:

md5sum_script = (

MD5SUM_DEVICE_SCRIPT_FORMAT.format(

path=p, md5sum_lib=MD5SUM_DEVICE_LIB_PATH,

« no previous file with comments | « build/android/pylib/utils/device_temp_file_test.py ('k') | no next file » | no next file with comments »