Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: content/test/layouttest_support.cc

Issue 751043002: Refactor RenderView creation to use ViewMsg_New_Params. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Charlie's review. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl_params.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/layouttest_support.cc
diff --git a/content/test/layouttest_support.cc b/content/test/layouttest_support.cc
index 10a7f3748f56ff9aa93e27f8607e4ec11ea2db26..10f497ba6467828736364137ffea8e1434b58974 100644
--- a/content/test/layouttest_support.cc
+++ b/content/test/layouttest_support.cc
@@ -48,8 +48,8 @@ namespace {
base::LazyInstance<base::Callback<void(RenderView*, WebTestProxyBase*)> >::Leaky
g_callback = LAZY_INSTANCE_INITIALIZER;
-RenderViewImpl* CreateWebTestProxy(RenderViewImplParams* params) {
- typedef WebTestProxy<RenderViewImpl, RenderViewImplParams*> ProxyType;
+RenderViewImpl* CreateWebTestProxy(const ViewMsg_New_Params& params) {
+ typedef WebTestProxy<RenderViewImpl, const ViewMsg_New_Params&> ProxyType;
ProxyType* render_view_proxy = new ProxyType(params);
if (g_callback == 0)
return render_view_proxy;
@@ -58,7 +58,7 @@ RenderViewImpl* CreateWebTestProxy(RenderViewImplParams* params) {
}
WebTestProxyBase* GetWebTestProxyBase(RenderViewImpl* render_view) {
- typedef WebTestProxy<RenderViewImpl, RenderViewImplParams*> ViewProxy;
+ typedef WebTestProxy<RenderViewImpl, ViewMsg_New_Params*> ViewProxy;
ViewProxy* render_view_proxy = static_cast<ViewProxy*>(render_view);
return static_cast<WebTestProxyBase*>(render_view_proxy);
« no previous file with comments | « content/renderer/render_view_impl_params.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698