Refactor RenderView creation to use ViewMsg_New_Params.

content/renderer/render_view_impl.h

Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index 6616acd91677e27344337b0865de62187bdaac5a..92df360307324da4758167c9c2f37c10c503d5b2 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -77,6 +77,7 @@ class PepperDeviceTest;
 class SkBitmap;
 struct PP_NetAddress_Private;
 struct FrameMsg_Navigate_Params;
+struct ViewMsg_New_Params;
 struct ViewMsg_PostMessage_Params;
 struct ViewMsg_Resize_Params;
 struct ViewMsg_StopFinding_Params;
@@ -164,30 +165,13 @@ class CONTENT_EXPORT RenderViewImpl
   // |opener_id| will be MSG_ROUTING_NONE. When |swapped_out| is true, the
   // |proxy_routing_id| is specified, so a RenderFrameProxy can be created for
   // this RenderView's main RenderFrame.
-  static RenderViewImpl* Create(int32 opener_id,
-                                bool window_was_created_with_opener,
-                                const RendererPreferences& renderer_prefs,
-                                const WebPreferences& webkit_prefs,
-                                int32 routing_id,
-                                int32 main_frame_routing_id,
-                                int32 surface_id,
-                                int64 session_storage_namespace_id,
-                                const base::string16& frame_name,
-                                bool is_renderer_created,
-                                bool swapped_out,
-                                int32 proxy_routing_id,
-                                bool hidden,
-                                bool never_visible,
-                                int32 next_page_id,
-                                const ViewMsg_Resize_Params& initial_size,
-                                bool enable_auto_resize,
-                                const gfx::Size& min_size,
-                                const gfx::Size& max_size);
+  static RenderViewImpl* Create(bool is_renderer_created,
+                                const ViewMsg_New_Params& params);

[Charlie Reis, 2014/11/24 23:28:21]

I kind of wish we could do this without taking an IPC struct here, but I think
this is better than requiring a manual copy between two identical structs.

The closest I could come up with is FrameNavigateParams (in content/common),
which is used in FrameHostMsg_DidCommitProvisionalLoad_Params via
IPC_STRUCT_TRAITS_PARENT.  That doesn't solve this problem, though, since we
would still need to take in the IPC struct here.  (For comparison,
NavigationControllerImpl::RendererDidNavigate takes in
FrameHostMsg_DidCommitProvisionalLoad_Params, not FrameNavigateParams.)

[nasko, 2014/11/24 23:47:55]

Thanks for looking into this! FYI, I've applied the same transform as for
Initialize to rename the boolean and add it as second param.

 
   // Used by content_layouttest_support to hook into the creation of
   // RenderViewImpls.
   static void InstallCreateHook(
-      RenderViewImpl* (*create_render_view_impl)(RenderViewImplParams*));
+      RenderViewImpl* (*create_render_view_impl)(const ViewMsg_New_Params&));
 
   // Returns the RenderViewImpl containing the given WebView.
   static RenderViewImpl* FromWebView(blink::WebView* webview);
@@ -539,9 +523,9 @@ class CONTENT_EXPORT RenderViewImpl
   void InstrumentWillComposite() override;
 
  protected:
-  explicit RenderViewImpl(RenderViewImplParams* params);
+  explicit RenderViewImpl(const ViewMsg_New_Params& params);
 
-  void Initialize(RenderViewImplParams* params);
+  void Initialize(bool is_renderer_created, const ViewMsg_New_Params& params);

[Charlie Reis, 2014/11/24 23:28:21]

nit: is_renderer_created isn't a great name, since it's easily misinterpreted. 
This code runs in the renderer process, so the renderer has necessarily been
created.

Maybe was_created_by_renderer?

I'd also list it second, since it's a supplement to params rather than something
that heavily affects the behavior of this method.

[nasko, 2014/11/24 23:47:55]

Done.

   void SetScreenMetricsEmulationParameters(float device_scale_factor,
                                            const gfx::Point& root_layer_offset,
                                            float root_layer_scale) override;