Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: Source/core/css/RuleFeature.cpp

Issue 751023002: Use SubSelector as relation on left-most selector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: SubSelector is not a combinator Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSSelector.h ('k') | Source/core/css/RuleSet.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 310 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 } 321 }
322 } 322 }
323 323
324 if (current->relation() == CSSSelector::SubSelector) 324 if (current->relation() == CSSSelector::SubSelector)
325 continue; 325 continue;
326 326
327 features.treeBoundaryCrossing = current->isShadowSelector(); 327 features.treeBoundaryCrossing = current->isShadowSelector();
328 features.adjacent = current->isAdjacentSelector(); 328 features.adjacent = current->isAdjacentSelector();
329 return std::make_pair(current->tagHistory(), foundFeatures ? UseFeatures : ForceSubtree); 329 return std::make_pair(current->tagHistory(), foundFeatures ? UseFeatures : ForceSubtree);
330 } 330 }
331 return std::make_pair(nullptr, ForceSubtree); 331 return std::make_pair(nullptr, foundFeatures ? UseFeatures : ForceSubtree);
332 } 332 }
333 333
334 // Add features extracted from the rightmost compound selector to descendant inv alidation 334 // Add features extracted from the rightmost compound selector to descendant inv alidation
335 // sets for features found in other compound selectors. 335 // sets for features found in other compound selectors.
336 // 336 //
337 // Style invalidation is currently supported for descendants only, not for sibli ng subtrees. 337 // Style invalidation is currently supported for descendants only, not for sibli ng subtrees.
338 // We use wholeSubtree invalidation for features found left of adjacent combinat ors as 338 // We use wholeSubtree invalidation for features found left of adjacent combinat ors as
339 // SubtreeStyleChange will force sibling subtree recalc in 339 // SubtreeStyleChange will force sibling subtree recalc in
340 // ContainerNode::checkForChildrenAdjacentRuleChanges. 340 // ContainerNode::checkForChildrenAdjacentRuleChanges.
341 // 341 //
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 visitor->trace(uncommonAttributeRules); 610 visitor->trace(uncommonAttributeRules);
611 visitor->trace(m_classInvalidationSets); 611 visitor->trace(m_classInvalidationSets);
612 visitor->trace(m_attributeInvalidationSets); 612 visitor->trace(m_attributeInvalidationSets);
613 visitor->trace(m_idInvalidationSets); 613 visitor->trace(m_idInvalidationSets);
614 visitor->trace(m_pseudoInvalidationSets); 614 visitor->trace(m_pseudoInvalidationSets);
615 visitor->trace(m_styleInvalidator); 615 visitor->trace(m_styleInvalidator);
616 #endif 616 #endif
617 } 617 }
618 618
619 } // namespace blink 619 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/css/CSSSelector.h ('k') | Source/core/css/RuleSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698