src/heap/heap.cc - Issue 750963002: Reduce context disposal gc overhead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 750963002: Reduce context disposal gc overhead. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index 9785be0b91d59785a5b38a6da7ac38006ed8bfa2..154a1ae8ed62851ef931f58af36d97d84f3da5ac 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -4451,8 +4451,7 @@ bool Heap::IdleNotification(int idle_time_in_ms) {

case DO_FULL_GC: {

HistogramTimerScope scope(isolate_->counters()->gc_context());

if (contexts_disposed_) {

- CollectAllGarbage(kReduceMemoryFootprintMask,

- "idle notification: contexts disposed");

+ CollectAllGarbage(kNoGCFlags, "idle notification: contexts disposed");

gc_idle_time_handler_.NotifyIdleMarkCompact();

gc_count_at_last_idle_gc_ = gc_count_;

} else {

« no previous file with comments | « src/heap/gc-tracer.cc ('k') | no next file » | no next file with comments »