Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: pkg/analyzer/test/generated/engine_test.dart

Issue 750953005: When the same contents is set for a source, we still need to reset its modification time. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/engine.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/engine_test.dart
diff --git a/pkg/analyzer/test/generated/engine_test.dart b/pkg/analyzer/test/generated/engine_test.dart
index 0f4501dfcb85d8c08a137c4d2e511f5981bf2381..2a6b9b8d7d5a5e4fd9cd7081acf2248e8ad533f4 100644
--- a/pkg/analyzer/test/generated/engine_test.dart
+++ b/pkg/analyzer/test/generated/engine_test.dart
@@ -1885,6 +1885,23 @@ int a = 0;''');
expect(_getIncrementalAnalysisCache(_context), isNull);
}
+ void test_setContents_unchanged_consistentModificationTime() {
+ String contents = "// foo";
+ Source source = _addSource("/test.dart", contents);
+ // do all, no tasks
+ _analyzeAll_assertFinished();
+ {
+ AnalysisResult result = _context.performAnalysisTask();
+ expect(result.changeNotices, isNull);
+ }
+ // set the same contents, still no tasks
+ _context.setContents(source, contents);
+ {
+ AnalysisResult result = _context.performAnalysisTask();
+ expect(result.changeNotices, isNull);
+ }
+ }
+
void test_setSourceFactory() {
expect(_context.sourceFactory, _sourceFactory);
SourceFactory factory = new SourceFactory([]);
@@ -6192,8 +6209,8 @@ class SourcesChangedEventTest {
void test_changedRange2() {
var source = new StringSource('', '/test.dart');
- var event = new SourcesChangedEvent.changedRange(
- source, 'library A;', 0, 0, 13);
+ var event =
+ new SourcesChangedEvent.changedRange(source, 'library A;', 0, 0, 13);
assertEvent(event, changedSources: [source]);
}
@@ -6227,9 +6244,9 @@ class SourcesChangedEventTest {
assertEvent(event, wereSourcesRemovedOrDeleted: true);
}
- static void assertEvent(SourcesChangedEvent event, {bool wereSourcesAdded: false,
- List<Source> changedSources: Source.EMPTY_ARRAY,
- bool wereSourcesRemovedOrDeleted: false}) {
+ static void assertEvent(SourcesChangedEvent event, {bool wereSourcesAdded:
+ false, List<Source> changedSources: Source.EMPTY_ARRAY,
+ bool wereSourcesRemovedOrDeleted: false}) {
expect(event.wereSourcesAdded, wereSourcesAdded);
expect(event.changedSources, changedSources);
expect(event.wereSourcesRemovedOrDeleted, wereSourcesRemovedOrDeleted);
@@ -6240,9 +6257,8 @@ class SourcesChangedEventTest {
class SourcesChangedListener {
List<SourcesChangedEvent> actualEvents = [];
- void assertEvent({bool wereSourcesAdded: false,
- List<Source> changedSources: Source.EMPTY_ARRAY,
- bool wereSourcesRemovedOrDeleted: false}) {
+ void assertEvent({bool wereSourcesAdded: false, List<Source> changedSources:
+ Source.EMPTY_ARRAY, bool wereSourcesRemovedOrDeleted: false}) {
if (actualEvents.isEmpty) {
fail('Expected event but found none');
}
« no previous file with comments | « pkg/analyzer/lib/src/generated/engine.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698