Modifying AX test for html select element

Modifying AX test for html select element.

Adding case when select element with multiple or size attribute is present.

BUG=169564
Committed: https://crrev.com/929152bfb4a0805e3a8e9822fa82409e682c8b22
Cr-Commit-Position: refs/heads/master@{#306135}

[shreeramk, 2014-11-25 06:23:34]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2014-11-25 06:23:34]

Still blink is returning PopupButtonRole for select tag.

Reason: AXMenuList.h

virtual AccessibilityRole roleValue() const override { return PopUpButtonRole; }

What does AXMenuList class does? Is it related with html menu tag??

[dmazzoni, 2014-11-25 07:55:46]

On 2014/11/25 06:23:34, shreeramk wrote:
> Still blink is returning PopupButtonRole for select tag.
> 
> Reason: AXMenuList.h
> 
> virtual AccessibilityRole roleValue() const override { return PopUpButtonRole;
}
> 
> What does AXMenuList class does? Is it related with html menu tag??

A "menu list" is what Blink calls a combo box where you can't type in your own
choice - it's a pop-up button that opens a menu with all of the choices.

AXMenuList is created in AXObjectCacheImpl::createFromRenderer

I think it might make more sense to stick with AXMenuList and map it to "combo
box" on Mac.

[dmazzoni, 2014-11-25 07:55:54]

https://codereview.chromium.org/750933002/diff/20001/content/test/data/access...
File content/test/data/accessibility/select.html (right):

https://codereview.chromium.org/750933002/diff/20001/content/test/data/access...
content/test/data/accessibility/select.html:25: <select id="D" name="Select D"
multiple="2">
What's also needed is <select size=10> (where 10 can be any number greater than
1) - this presents a list box like <select multiple> but you can only select
one.

[shreeramk, 2014-11-25 08:03:21]

On 2014/11/25 07:55:46, dmazzoni wrote:
> On 2014/11/25 06:23:34, shreeramk wrote:
> > Still blink is returning PopupButtonRole for select tag.
> > 
> > Reason: AXMenuList.h
> > 
> > virtual AccessibilityRole roleValue() const override { return
PopUpButtonRole;
> }
> > 
> > What does AXMenuList class does? Is it related with html menu tag??
> 
> A "menu list" is what Blink calls a combo box where you can't type in your own
> choice - it's a pop-up button that opens a menu with all of the choices.
> 
> AXMenuList is created in AXObjectCacheImpl::createFromRenderer
> 
> I think it might make more sense to stick with AXMenuList and map it to "combo
> box" on Mac.


Ok. So, you mean to say this?

{ui::AX_ROLE_POP_UP_BUTTON, NSAccessibilityComboBoxRole},

[shreeramk, 2014-11-25 18:09:06]

Comments incorporated. PTAL.

Thanks!!

[shreeramk, 2014-11-26 19:11:04]

@Dominic: Please review the changes. I have incorporated the changes.

[dmazzoni, 2014-11-26 23:22:06]

Sorry, was just looking over the spec again and I'm not sure all of these
changes are right.

The spec says that "select (with NO multiple attribute and NO size attribute
having value greater than 1)" should have a default Platform WAI-ARIA Role of
"combobox". I don't think that means that on Mac it should have a Mac role of
AXComboBox necessarily.

The spec doesn't currently say how to map a <select> element, I'm not sure why
it was taken out.

[shreeramk, 2014-11-27 04:14:56]

On 2014/11/26 23:22:06, dmazzoni wrote:
> Sorry, was just looking over the spec again and I'm not sure all of these
> changes are right.
> 
> The spec says that "select (with NO multiple attribute and NO size attribute
> having value greater than 1)" should have a default Platform WAI-ARIA Role of
> "combobox". I don't think that means that on Mac it should have a Mac role of
> AXComboBox necessarily.

According to spec ARIA role combo box on mac is exposed as below 

AXRole: AXComboBox
AXSubrole: <nil>
AXRoleDescription: 'combo box'

So, select (with NO multiple attribute and NO size attribute having value
greater than 1) would be exposed similar to aria role combobox. Right??

[dmazzoni, 2014-11-27 07:45:48]

>
> So, select (with NO multiple attribute and NO size attribute having value
> greater than 1) would be exposed similar to aria role combobox. Right??
>

No, I don't think that follows.

The reason why is because on Mac at least, AXPopUpButton is a better
description of a <select> than AXComboBox is.

ARIA roles originally came from Windows. On Windows, a combo box is a
control that looks like a text field, but with an option to choose from a
list of values. Sometimes you can type into a combo box, to pick a value
that's not from a list - but sometimes you can't, you can only choose one
from the list. On Windows, and in ARIA, the term "combo box" is ambiguous -
it can refer to either one.

On Mac, it's not ambiguous. If it's a control that pops up a list, and you
can only choose from the list and not type your own value, it's a "menu
list", and the AX role is "menu button". If it's a text field that also has
an option to choose from a list (but you can type whatever you want), then
it's a combo box.



- Dominic

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-11-27 07:50:22]

> On Mac, it's not ambiguous. If it's a control that pops up a list, and you
> can only choose from the list and not type your own value, it's a "menu
> list", and the AX role is "menu button". If it's a text field that also has
> an option to choose from a list (but you can type whatever you want), then
> it's a combo box.

But there is no AXRole like AXPopUpButton defined in spec.

[dmazzoni, 2014-11-27 07:53:19]

The original AAPI mapped <select> to AXPopUpButton:
http://www.w3.org/TR/html-aapi/

That section is noticeably absent from the latest draft. I think that's an
error.

On Wed, Nov 26, 2014 at 11:50 PM, <shreeram.k@samsung.com> wrote:

>
>  On Mac, it's not ambiguous. If it's a control that pops up a list, and you
>> can only choose from the list and not type your own value, it's a "menu
>> list", and the AX role is "menu button". If it's a text field that also
>> has
>> an option to choose from a list (but you can type whatever you want), then
>> it's a combo box.
>>
>
> But there is no AXRole like AXPopUpButton defined in spec.
>
>
> https://codereview.chromium.org/750933002/
>
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-reviews+unsubscribe@chromium.org.
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-11-27 08:18:13]

Yes, in old spec it was AXPopupButton.

Ok. I'd make like how it was before.

[dmazzoni, 2014-11-27 08:19:43]

OK. At first glance, maybe we only want a difference on Windows, since
Windows exposes the equivalent ARIA role and it should now be "combobox".

On Thu, Nov 27, 2014 at 12:18 AM, <shreeram.k@samsung.com> wrote:

> Yes, in old spec it was AXPopupButton.
>
> Ok. I'd make like how it was before.
>
> https://codereview.chromium.org/750933002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-11-27 08:26:48]

On 2014/11/27 08:19:43, dmazzoni wrote:
> OK. At first glance, maybe we only want a difference on Windows, since
> Windows exposes the equivalent ARIA role and it should now be "combobox".
> 
> On Thu, Nov 27, 2014 at 12:18 AM, <mailto:shreeram.k@samsung.com> wrote:
> 
> > Yes, in old spec it was AXPopupButton.
> >
> > Ok. I'd make like how it was before.
> >
> > https://codereview.chromium.org/750933002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

On windows, its already ROLE_SYSTEM_COMBOBOX.

case ui::AX_ROLE_POP_UP_BUTTON:
      if (html_tag == L"select") {
        ia_role_ = ROLE_SYSTEM_COMBOBOX;
      } else {
        ia_role_ = ROLE_SYSTEM_BUTTONMENU;
      }
      break;

[shreeramk, 2014-11-27 18:05:43]

On 2014/11/27 08:26:48, shreeramk wrote:
> On 2014/11/27 08:19:43, dmazzoni wrote:
> > OK. At first glance, maybe we only want a difference on Windows, since
> > Windows exposes the equivalent ARIA role and it should now be "combobox".
> > 
> > On Thu, Nov 27, 2014 at 12:18 AM, <mailto:shreeram.k@samsung.com> wrote:
> > 
> > > Yes, in old spec it was AXPopupButton.
> > >
> > > Ok. I'd make like how it was before.
> > >
> > > https://codereview.chromium.org/750933002/
> > >
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.
> 
> On windows, its already ROLE_SYSTEM_COMBOBOX.
> 
> case ui::AX_ROLE_POP_UP_BUTTON:
>       if (html_tag == L"select") {
>         ia_role_ = ROLE_SYSTEM_COMBOBOX;
>       } else {
>         ia_role_ = ROLE_SYSTEM_BUTTONMENU;
>       }
>       break;

[shreeramk, 2014-11-27 18:06:09]

Please take a look. Thanks!

[dmazzoni, 2014-11-29 07:52:18]

lgtm

Looks great, but the change description is still out of date. Please rewrite it
before committing. Thanks!

https://codereview.chromium.org/750933002/diff/120001/content/test/data/acces...
File content/test/data/accessibility/select.html (right):

https://codereview.chromium.org/750933002/diff/120001/content/test/data/acces...
content/test/data/accessibility/select.html:6: @WIN-ALLOW:HASPOPUP
Optional: consider @WIN-ALLOW:xml-roles to show that you get an equivalent ARIA
role of combobox, etc?

[shreeramk, 2014-11-30 12:38:52]

>
https://codereview.chromium.org/750933002/diff/120001/content/test/data/acces...
> content/test/data/accessibility/select.html:6: @WIN-ALLOW:HASPOPUP
> Optional: consider @WIN-ALLOW:xml-roles to show that you get an equivalent
ARIA
> role of combobox, etc?

In a little old spec, http://rawgit.com/w3c/html-api-map/master/index.html
HTML elements were not directly mapped to Existing WAI-ARIA Role Semantics.
Thats why currently xml-roles are not exposed for HTML select element.

But in latest editor draft
http://rawgit.com/w3c/aria/master/html-aam/html-aam.html,
"HTML elements with default WAI-ARIA role semantics MUST be mapped to platform
accessibility APIs according to those WAI-ARIA roles' mappings as defined in the
Core Accessibility API Mappings specification."

So, I am thinking of submitting a separate single CL to expose xml-roles for all
html elements with default WAI-ARIA roles semantics according to latest editor's
draft.

Whats your views on this??

[shreeramk, 2014-11-30 12:45:47]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-11-30 12:45:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/750933002/120001

[commit-bot: I haz the power, 2014-11-30 14:34:22]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2014-11-30 14:35:07]

Patchset 7 (id:??) landed as
https://crrev.com/929152bfb4a0805e3a8e9822fa82409e682c8b22
Cr-Commit-Position: refs/heads/master@{#306135}