Issue 750863003: text-align-last is no longer depend on text-justify

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 750863003: text-align-last is no longer depend on text-justify (Closed)

Created:
6 years ago by dw.im

Modified:
6 years ago

Reviewers:
pdr., kojii, eae

CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

text-align-last is no longer depend on text-justify Regarding the spcification change, text-align-last is only depend on text-align. Hence, removing the dependency to text-justify. BUG=248839 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186646

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -30 lines)			Patch
M	LayoutTests/fast/css3-text/css3-text-align-last/text-align-last.html	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	LayoutTests/fast/css3-text/css3-text-align-last/text-align-last-expected.html	View	1 chunk	+12 lines, -12 lines	0 comments	Download
M	Source/core/rendering/RenderBlockLineLayout.cpp	View	2 chunks	+3 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750863003/1

6 years ago (2014-12-06 15:54:30 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-06 16:44:19 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186646

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages