Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: src/api.cc

Issue 750813003: Use deadline in IdleNotification. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index cf032a1fe8903851f3e53a18f4f19cff8d4712fe..8c36e953617f66a747bab0215786bd1e7cf779e4 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -6629,6 +6629,15 @@ bool Isolate::IdleNotification(int idle_time_in_ms) {
}
+bool Isolate::IdleNotification(double deadline_in_seconds) {
+ // Returning true tells the caller that it need not
+ // continue to call IdleNotification.
+ i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
+ if (!i::FLAG_use_idle_notification) return true;
+ return isolate->heap()->IdleNotification(deadline_in_seconds);
rmcilroy 2014/11/25 14:28:06 you need to multiply by 1000 right? Could we just
Hannes Payer (out of office) 2014/11/25 16:01:36 I moved the conversion to the actual IdleNotificat
+}
+
+
void Isolate::LowMemoryNotification() {
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(this);
{

Powered by Google App Engine
This is Rietveld 408576698