Safebrowsing download protection: also check blob URLs.

Safebrowsing download protection: also check blob URLs.

BUG=431187
Committed: https://crrev.com/e77e1c6d3ecf6398fdbd32fd262e6d6d5e00c4bd
Cr-Commit-Position: refs/heads/master@{#306686}

[mattm, 2014-11-22 02:04:01]

mattm@chromium.org changed reviewers:
+ noelutz@chromium.org

[mattm, 2014-11-25 03:03:52]

ping

[noé, 2014-12-03 00:56:40]

lgtm

https://codereview.chromium.org/750773003/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/download_protection_service.cc (right):

https://codereview.chromium.org/750773003/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/download_protection_service.cc:472: *reason =
REASON_UNSUPPORTED_URL_SCHEME;
What other schemes are there?  Just curious.

[mattm, 2014-12-03 01:00:37]

On 2014/12/03 00:56:40, noé wrote:
> lgtm
> 
>
https://codereview.chromium.org/750773003/diff/1/chrome/browser/safe_browsing...
> File chrome/browser/safe_browsing/download_protection_service.cc (right):
> 
>
https://codereview.chromium.org/750773003/diff/1/chrome/browser/safe_browsing...
> chrome/browser/safe_browsing/download_protection_service.cc:472: *reason =
> REASON_UNSUPPORTED_URL_SCHEME;
> What other schemes are there?  Just curious.

https://code.google.com/p/chromium/codesearch#chromium/src/url/url_constants.cc
Though that's not an exhaustive list ("chrome://" at least is another)

[mattm, 2014-12-03 01:02:53]

On 2014/12/03 01:00:37, mattm wrote:
> On 2014/12/03 00:56:40, noé wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/750773003/diff/1/chrome/browser/safe_browsing...
> > File chrome/browser/safe_browsing/download_protection_service.cc (right):
> > 
> >
>
https://codereview.chromium.org/750773003/diff/1/chrome/browser/safe_browsing...
> > chrome/browser/safe_browsing/download_protection_service.cc:472: *reason =
> > REASON_UNSUPPORTED_URL_SCHEME;
> > What other schemes are there?  Just curious.
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/url/url_constants.cc
> Though that's not an exhaustive list ("chrome://" at least is another)

And
https://code.google.com/p/chromium/codesearch#chromium/src/url/url_util.cc&rc...
is the schemes considered "Standard".

[mattm, 2014-12-03 01:03:54]

mattm@chromium.org changed reviewers:
+ jwd@chromium.org

[mattm, 2014-12-03 01:03:54]

+jwd for histograms

[jwd, 2014-12-03 18:32:24]

lgtm

[mattm, 2014-12-03 20:45:28]

The CQ bit was checked by mattm@chromium.org

[commit-bot: I haz the power, 2014-12-03 20:46:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/750773003/1

[commit-bot: I haz the power, 2014-12-03 22:17:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-03 22:18:52]

Patchset 1 (id:??) landed as
https://crrev.com/e77e1c6d3ecf6398fdbd32fd262e6d6d5e00c4bd
Cr-Commit-Position: refs/heads/master@{#306686}