Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 750723002: add endRecordingAsDrawable experiment (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add endRecordingAsDrawable experiment BUG=skia:

Patch Set 1 #

Patch Set 2 : seems to work, TODO around immediate mode drawing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -46 lines) Patch
M include/core/SkPicture.h View 2 chunks +2 lines, -1 line 0 comments Download
M include/core/SkPictureRecorder.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M samplecode/SampleArc.cpp View 1 6 chunks +15 lines, -6 lines 0 comments Download
M src/core/SkCanvasDrawable.h View 3 chunks +3 lines, -6 lines 0 comments Download
M src/core/SkCanvasDrawable.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkPicture.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 4 chunks +83 lines, -0 lines 0 comments Download
M src/core/SkRecord.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkRecorder.h View 3 chunks +21 lines, -3 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 3 chunks +28 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
reed1
6 years, 1 month ago (2014-11-21 23:03:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750723002/20001
6 years, 1 month ago (2014-11-21 23:04:51 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 23:04:52 UTC) #5 
Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-22 05:04 UTC

Powered by Google App Engine
This is Rietveld 408576698