Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 750713004: Updating MakeMenuItemStringsFor() to mark disabled and checked menuitems. (Closed)

Created:
6 years ago by pals
Modified:
6 years ago
Reviewers:
tkent
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updating MakeMenuItemStringsFor() to mark disabled and checked menuitems. BUG=87553 Committed: https://crrev.com/a62675ee13f49fb2783daf5ab04ac3aba7d0ce99 Cr-Commit-Position: refs/heads/master@{#305928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M content/shell/renderer/test_runner/event_sender.cc View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pals
PTAL.
6 years ago (2014-11-26 10:47:40 UTC) #2
tkent
lgtm
6 years ago (2014-11-27 00:04:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750713004/1
6 years ago (2014-11-27 00:06:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-27 00:47:38 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-27 00:48:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a62675ee13f49fb2783daf5ab04ac3aba7d0ce99
Cr-Commit-Position: refs/heads/master@{#305928}

Powered by Google App Engine
This is Rietveld 408576698