Chromecast: adds media::Renderer implementation for CMA pipeline.

Chromecast: adds media::Renderer implementation for CMA pipeline.

BUG=408189
Committed: https://crrev.com/38f42e689d26db82d2a3c165a8dc171712066299
Cr-Commit-Position: refs/heads/master@{#307277}

[gunsch, 2014-12-06 01:06:58]

gunsch@chromium.org changed reviewers:
+ damienv@chromium.org, xhwang@chromium.org

[gunsch, 2014-12-06 01:06:59]

This doesn't involve creating/injecting the CmaRenderer instance yet; we still
needs our actual IPC code on both browser/renderer sides first. This is just the
Chromecast implementation of ::media::Renderer.

[damienv1, 2014-12-06 01:09:36]

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
File chromecast/media/cma/filters/cma_renderer.cc (right):

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
chromecast/media/cma/filters/cma_renderer.cc:349: else {
nit: } else {

[lcwu1, 2014-12-06 02:30:11]

lcwu@chromium.org changed reviewers:
+ lcwu@chromium.org

[lcwu1, 2014-12-06 02:30:12]

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
File chromecast/media/cma/filters/cma_renderer.cc (right):

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
chromecast/media/cma/filters/cma_renderer.cc:144: // Create a video hole frame
in the initial preroll.
The comment is a bit updated. The reference to 'preroll' here should be removed.
(Here, we can simply say 'Create a video hole.')

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
chromecast/media/cma/filters/cma_renderer.cc:149: // right before the pipeline
calls DoInitialPreroll (in
Change 'DoInitialPreroll' to 'StartPlayingFrom'.

[damienv1, 2014-12-08 16:47:23]

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
File chromecast/media/cma/filters/cma_renderer.cc (right):

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
chromecast/media/cma/filters/cma_renderer.cc:212: #if
defined(ENABLE_BROWSER_CDMS)
nit: don't think this #ifdef is needed (only on the browser side).

The MediaPipeline interface has this SeyCdm regardless of ENABLE_BROWSER_CDMS)

[gunsch, 2014-12-08 17:04:58]

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
File chromecast/media/cma/filters/cma_renderer.cc (right):

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
chromecast/media/cma/filters/cma_renderer.cc:144: // Create a video hole frame
in the initial preroll.
On 2014/12/06 02:30:11, lcwu1 wrote:
> The comment is a bit updated. The reference to 'preroll' here should be
removed.
> (Here, we can simply say 'Create a video hole.')

Done.

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
chromecast/media/cma/filters/cma_renderer.cc:149: // right before the pipeline
calls DoInitialPreroll (in
On 2014/12/06 02:30:11, lcwu1 wrote:
> Change 'DoInitialPreroll' to 'StartPlayingFrom'.

Done.

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
chromecast/media/cma/filters/cma_renderer.cc:212: #if
defined(ENABLE_BROWSER_CDMS)
CdmContext::GetCdmId() is only defined for ENABLE_BROWSER_CDMS.

https://codereview.chromium.org/750683003/diff/20001/chromecast/media/cma/fil...
chromecast/media/cma/filters/cma_renderer.cc:349: else {
On 2014/12/06 01:09:36, damienv1 wrote:
> nit: } else {

Done.

[lcwu1, 2014-12-08 17:18:07]

lgtm

[damienv1, 2014-12-08 17:18:26]

lgtm

[gunsch, 2014-12-08 17:26:00]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-12-08 17:27:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/750683003/40001

[commit-bot: I haz the power, 2014-12-08 18:14:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-08 18:15:32]

Patchset 3 (id:??) landed as
https://crrev.com/38f42e689d26db82d2a3c165a8dc171712066299
Cr-Commit-Position: refs/heads/master@{#307277}