Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 750663002: Remove DOMStringList. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove DOMStringList. This was for location.ancestorOrigins which Sky doesn't support. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eb225f581d393f10ddf64611f426ff93b39f0b96

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -172 lines) Patch
M sky/engine/core/core.gni View 2 chunks +0 lines, -3 lines 0 comments Download
D sky/engine/core/dom/DOMStringList.h View 1 chunk +0 lines, -70 lines 0 comments Download
D sky/engine/core/dom/DOMStringList.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D sky/engine/core/dom/DOMStringList.idl View 1 chunk +0 lines, -31 lines 0 comments Download
M sky/engine/core/frame/Location.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/frame/Location.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/frame/Location.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-21 19:08:16 UTC) #2
esprehn
6 years, 1 month ago (2014-11-21 20:06:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb225f581d393f10ddf64611f426ff93b39f0b96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698