content/browser/permissions/permission_service_impl.cc - Issue 750633003: Implement HasPermission() method in PermissionService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/permissions/permission_service_impl.cc

Issue 750633003: Implement HasPermission() method in PermissionService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add dependencies to content_app, content_child and content_ppapi_plugin Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/permissions/permission_service_context.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | content/public/common/permission_status.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/permissions/permission_service_impl.cc

diff --git a/content/browser/permissions/permission_service_impl.cc b/content/browser/permissions/permission_service_impl.cc

index 12638e8c4ee1fa5c3bfe071e9829a0d82eba3c3d..bb5b027742907b8ebf25ae8d1feff364460c35ea 100644

--- a/content/browser/permissions/permission_service_impl.cc

+++ b/content/browser/permissions/permission_service_impl.cc

@@ -109,7 +109,16 @@ void PermissionServiceImpl::HasPermission(

PermissionName permission,

const mojo::String& origin,

const mojo::Callback<void(PermissionStatus)>& callback) {

- NOTIMPLEMENTED();

+ DCHECK(context_->GetBrowserContext());

+ // If the embedding_origin is empty we'll use |origin| instead.

+ GURL embedding_origin = context_->GetEmbeddingOrigin();

+ callback.Run(GetContentClient()->browser()->GetPermissionStatus(

+ PermissionNameToPermissionType(permission),

+ context_->GetBrowserContext(),

+ GURL(origin),

+ embedding_origin.is_empty() ? GURL(origin) : embedding_origin));

}

} // namespace content