content/browser/permissions/permission_service_impl.h - Issue 750633003: Implement HasPermission() method in PermissionService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/permissions/permission_service_impl.h

Issue 750633003: Implement HasPermission() method in PermissionService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed comments, switched to use BrowserContext, passing PermissionStatus in callback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_content_browser_client.cc ('K') | « content/browser/permissions/permission_service_context.cc ('k') | content/browser/permissions/permission_service_impl.cc » ('j') | content/browser/permissions/permission_service_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/permissions/permission_service_impl.h

diff --git a/content/browser/permissions/permission_service_impl.h b/content/browser/permissions/permission_service_impl.h

index c67ae88ef1d1fa3e5094a5ebcb99d7ee004a12de..42875923b38f9a22c84cc64374f6d1655737efea 100644

--- a/content/browser/permissions/permission_service_impl.h

+++ b/content/browser/permissions/permission_service_impl.h

@@ -60,6 +60,10 @@ class PermissionServiceImpl : public mojo::InterfaceImpl<PermissionService> {

int request_id,

bool allowed);

+ void OnHasPermissionResponse(

+ const mojo::Callback<void(PermissionStatus)>& callback,

+ PermissionStatus content_setting);

mlamouri (slow - plz ping) 2014/11/24 19:06:01 nit: s/content_setting/permission_status/

timvolodine 2014/11/27 17:53:42 Done.

RequestsMap pending_requests_;

// context_ owns |this|.

PermissionServiceContext* context_;