Add pop_back to GrTRecorder.h

Add pop_back to GrTRecorder.h

Committed: https://skia.googlesource.com/skia/+/77d77f446d1685cd21465627a747341c3c3665e4

[bsalomon, 2014-11-21 16:23:08]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, joshualitt@google.com

[bsalomon, 2014-11-21 16:23:08]

This is necessary to be able to create the opt state once in iodb's cmd buffer
and then delete if it isn't necessary.

[egdaniel, 2014-11-21 19:09:47]

lgtm. Main suggestion is adding more commenting throughout code so that someone
can quickly understand how memory is allocated in this structure.

https://codereview.chromium.org/750613002/diff/60001/src/gpu/GrTRecorder.h
File src/gpu/GrTRecorder.h (right):

https://codereview.chromium.org/750613002/diff/60001/src/gpu/GrTRecorder.h#ne...
src/gpu/GrTRecorder.h:115: static MemBlock* Alloc(int length, MemBlock* prev) {
Add comment on what length means when we alloc MemBlocks (aka number of TAligns)

https://codereview.chromium.org/750613002/diff/60001/src/gpu/GrTRecorder.h#ne...
src/gpu/GrTRecorder.h:147: int       fBack;
comment about what this is

https://codereview.chromium.org/750613002/diff/60001/src/gpu/GrTRecorder.h#ne...
src/gpu/GrTRecorder.h:177: if (!header->fPrevLength) {
comment about what this if tells about the state we are in

https://codereview.chromium.org/750613002/diff/60001/src/gpu/GrTRecorder.h#ne...
src/gpu/GrTRecorder.h:182: if (!fTailBlock->fBack) {
comment about what this if tells about the state we are in

[bsalomon, 2014-11-21 22:25:08]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-11-21 22:25:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/750613002/80001

[commit-bot: I haz the power, 2014-11-21 22:38:12]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/77d77f446d1685cd21465627a747341c3c3665e4