Source/core/html/HTMLBodyElement.cpp - Issue 750523002: Remove <body bgproperties=fixed>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLBodyElement.cpp

Issue 750523002: Remove <body bgproperties=fixed> (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLBodyElement.cpp

diff --git a/Source/core/html/HTMLBodyElement.cpp b/Source/core/html/HTMLBodyElement.cpp

index 12b2b375d3d619724fd3c38aa0652d004116d80e..c855c82efd216db3f03ca1b4ffeb019dd2497f65 100644

--- a/Source/core/html/HTMLBodyElement.cpp

+++ b/Source/core/html/HTMLBodyElement.cpp

@@ -55,7 +55,7 @@ HTMLBodyElement::~HTMLBodyElement()

bool HTMLBodyElement::isPresentationAttribute(const QualifiedName& name) const

{

- if (name == backgroundAttr || name == marginwidthAttr || name == leftmarginAttr || name == marginheightAttr || name == topmarginAttr || name == bgcolorAttr || name == textAttr || name == bgpropertiesAttr)

+ if (name == backgroundAttr || name == marginwidthAttr || name == leftmarginAttr || name == marginheightAttr || name == topmarginAttr || name == bgcolorAttr || name == textAttr)

return true;

return HTMLElement::isPresentationAttribute(name);

}

@@ -80,13 +80,9 @@ void HTMLBodyElement::collectStyleForPresentationAttribute(const QualifiedName&

addHTMLColorToStyle(style, CSSPropertyBackgroundColor, value);

} else if (name == textAttr) {

addHTMLColorToStyle(style, CSSPropertyColor, value);

- } else if (name == bgpropertiesAttr) {

- if (equalIgnoringCase(value, "fixed")) {

- UseCounter::countDeprecation(document(), UseCounter::BgPropertiesFixed);

- addPropertyToPresentationAttributeStyle(style, CSSPropertyBackgroundAttachment, CSSValueFixed);

- }

- } else

+ } else {

HTMLElement::collectStyleForPresentationAttribute(name, value, style);

+ }

}

void HTMLBodyElement::parseAttribute(const QualifiedName& name, const AtomicString& value)

« no previous file with comments | « Source/core/html/HTMLAttributeNames.in ('k') | no next file » | no next file with comments »