Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 750353008: Remove the tagNamesToSkip argument on MarkupAccumulator::serializeNodes (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
fs
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove the tagNamesToSkip argument on MarkupAccumulator::serializeNodes The tagNamesToSkip vector was introduced in WebKit in 2012: http://trac.webkit.org/changeset/116685 It was used by Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp, which was removed in Blink in 2013: https://src.chromium.org/viewvc/blink?revision=147676&view=revision Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186186

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M Source/core/editing/MarkupAccumulator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 3 chunks +4 lines, -11 lines 0 comments Download
M Source/core/editing/markup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years ago (2014-11-28 13:57:10 UTC) #2
fs
lgtm
6 years ago (2014-11-28 14:11:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750353008/1
6 years ago (2014-11-28 14:11:52 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-28 15:05:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186186

Powered by Google App Engine
This is Rietveld 408576698