Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 750333004: Change rendering code to use RenderObject::resolveColor (Closed)

Created:
6 years ago by rwlbuis
Modified:
6 years ago
Reviewers:
eae
CC:
blink-reviews, shans, eae+blinkwatch, fs, kouhei+svg_chromium.org, rwlbuis, krit, dstockwell, Timothy Loh, jchaffraix+rendering, blink-reviews-paint_chromium.org, pdr+svgwatchlist_chromium.org, Eric Willigers, Steve Block, rjwright, zoltan1, Dominik Röttsches, gyuyoung.kim_webkit.org, darktears, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Change rendering code to use RenderObject::resolveColor Change our rendering code to use RenderObject::resolveColor( colorPropertyId) instead of RenderStyle::visitedDependentColor colorPropertyId) or RenderStyle::colorProperty() directly. This results in shorter more readable code. BUG=261858 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/paint/TableCellPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedColor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL
6 years ago (2014-12-04 19:02:38 UTC) #2
eae
LGTM
6 years ago (2014-12-04 19:28:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750333004/1
6 years ago (2014-12-04 19:38:08 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-04 21:06:31 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186537

Powered by Google App Engine
This is Rietveld 408576698