Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/compiler/dart2js/js_parser_test.dart

Issue 750323003: Remove js.ArrayElement. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/js_parser_statements_test.dart ('k') | tests/compiler/dart2js/type_representation_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/js_parser_test.dart
diff --git a/tests/compiler/dart2js/js_parser_test.dart b/tests/compiler/dart2js/js_parser_test.dart
index a5f923b989edb2057a08d63ccba4d5c9fd47028f..e3768a373652dc1d702ae0d748af0b642bfea87e 100644
--- a/tests/compiler/dart2js/js_parser_test.dart
+++ b/tests/compiler/dart2js/js_parser_test.dart
@@ -174,11 +174,13 @@ void main() {
testExpression("[]"),
testError("[42 42]"),
testExpression('beebop([1, 2, 3])'),
- // *We can't parse array literals with holes in them.
- testError("[1,, 2]"),
- testError("[1,]"),
- testError("[,]"),
- testError("[, 42]"),
+ // Array literals with holes in them.
+ testExpression("[1,, 2]"),
+ testExpression("[1,]", "[1]"),
+ testExpression("[1,,]", "[1,,]"),
+ testExpression("[,]"),
+ testExpression("[,,]"),
+ testExpression("[, 42]"),
// Ternary operator.
testExpression("x = a ? b : c"),
testExpression("y = a == null ? b : a"),
« no previous file with comments | « tests/compiler/dart2js/js_parser_statements_test.dart ('k') | tests/compiler/dart2js/type_representation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698