Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart

Issue 750323003: Remove js.ArrayElement. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 /** 7 /**
8 * A data structure for collecting fragments of a class definition. 8 * A data structure for collecting fragments of a class definition.
9 */ 9 */
10 class ClassBuilder { 10 class ClassBuilder {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 } 44 }
45 buffer.write(';'); 45 buffer.write(';');
46 } 46 }
47 buffer.writeAll(fields, ','); 47 buffer.writeAll(fields, ',');
48 var classData = js.string('$buffer'); 48 var classData = js.string('$buffer');
49 if (fieldMetadata != null) { 49 if (fieldMetadata != null) {
50 // If we need to store fieldMetadata, classData is turned into an array, 50 // If we need to store fieldMetadata, classData is turned into an array,
51 // and the field metadata is appended. So if classData is just a string, 51 // and the field metadata is appended. So if classData is just a string,
52 // there is no field metadata. 52 // there is no field metadata.
53 classData = 53 classData =
54 new jsAst.ArrayInitializer.from([classData]..addAll(fieldMetadata)); 54 new jsAst.ArrayInitializer([classData]..addAll(fieldMetadata));
55 } 55 }
56 List<jsAst.Property> fieldsAndProperties; 56 List<jsAst.Property> fieldsAndProperties;
57 if (!omitClassDescriptor) { 57 if (!omitClassDescriptor) {
58 fieldsAndProperties = <jsAst.Property>[]; 58 fieldsAndProperties = <jsAst.Property>[];
59 fieldsAndProperties.add( 59 fieldsAndProperties.add(
60 new jsAst.Property( 60 new jsAst.Property(
61 js.string(namer.classDescriptorProperty), classData)); 61 js.string(namer.classDescriptorProperty), classData));
62 fieldsAndProperties 62 fieldsAndProperties
63 ..addAll(properties); 63 ..addAll(properties);
64 } else { 64 } else {
65 fieldsAndProperties = properties; 65 fieldsAndProperties = properties;
66 } 66 }
67 return new jsAst.ObjectInitializer(fieldsAndProperties, isOneLiner: false); 67 return new jsAst.ObjectInitializer(fieldsAndProperties, isOneLiner: false);
68 } 68 }
69 } 69 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698