Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/old_emitter/class_builder.dart

Issue 750323003: Remove js.ArrayElement. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Add parsing and testing of array holes, make lists non-growable Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.js_emitter; 5 part of dart2js.js_emitter;
6 6
7 /** 7 /**
8 * A data structure for collecting fragments of a class definition. 8 * A data structure for collecting fragments of a class definition.
9 */ 9 */
10 class ClassBuilder { 10 class ClassBuilder {
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 } 43 }
44 buffer.write(';'); 44 buffer.write(';');
45 } 45 }
46 buffer.writeAll(fields, ','); 46 buffer.writeAll(fields, ',');
47 var classData = js.string('$buffer'); 47 var classData = js.string('$buffer');
48 if (fieldMetadata != null) { 48 if (fieldMetadata != null) {
49 // If we need to store fieldMetadata, classData is turned into an array, 49 // If we need to store fieldMetadata, classData is turned into an array,
50 // and the field metadata is appended. So if classData is just a string, 50 // and the field metadata is appended. So if classData is just a string,
51 // there is no field metadata. 51 // there is no field metadata.
52 classData = 52 classData =
53 new jsAst.ArrayInitializer.from([classData]..addAll(fieldMetadata)); 53 new jsAst.ArrayInitializer([classData]..addAll(fieldMetadata));
54 } 54 }
55 var fieldsAndProperties = 55 var fieldsAndProperties =
56 [new jsAst.Property(js.string(namer.classDescriptorProperty), 56 [new jsAst.Property(js.string(namer.classDescriptorProperty),
57 classData)] 57 classData)]
58 ..addAll(properties); 58 ..addAll(properties);
59 return new jsAst.ObjectInitializer(fieldsAndProperties, isOneLiner: false); 59 return new jsAst.ObjectInitializer(fieldsAndProperties, isOneLiner: false);
60 } 60 }
61 61
62 } 62 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698