Remove js.ArrayElement.

pkg/compiler/lib/src/js/template.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js;
 
 class TemplateManager {
   Map<String, Template> expressionTemplates = new Map<String, Template>();
   Map<String, Template> statementTemplates = new Map<String, Template>();
 
@@ skipping 594 matching lines @@
   Instantiator visitLiteralString(LiteralString node) =>
       (arguments) => new LiteralString(node.value);
 
   Instantiator visitLiteralNumber(LiteralNumber node) =>
       (arguments) => new LiteralNumber(node.value);
 
   Instantiator visitLiteralNull(LiteralNull node) =>
       (arguments) => new LiteralNull();
 
   Instantiator visitArrayInitializer(ArrayInitializer node) {
-    // Assume array has no missing elements.
     // TODO(sra): Implement splicing?
     List<Instantiator> elementMakers = node.elements
-        .map((ArrayElement element) => visit(element.value))
+        .map((Expression element) => visit(element))
         .toList();

[floitsch, 2014/11/28 12:42:50]

could be "growable: false".

[sigurdm, 2014/11/28 14:52:11]

Done.

     return (arguments) {
-      List<ArrayElement> elements = <ArrayElement>[];
-      void add(Expression value) {
-        elements.add(new ArrayElement(elements.length, value));
-      }
-      for (Instantiator instantiator in elementMakers) {
-        var result = instantiator(arguments);
-        add(result);
-      }
-      return new ArrayInitializer(elements.length, elements);
+      List<Expression> elements = elementMakers.map(

[floitsch, 2014/11/28 12:42:50]

I prefer:

  List<Expression> elements = elementMakers
      .map((Instantiator instantiator) => instantiator(arguments))
      .toList(growable: false);

[sigurdm, 2014/11/28 14:52:12]

Done.

+          (Instantiator instantiator) => instantiator(arguments)).toList();
+      return new ArrayInitializer(elements);
     };
   }
 
-  Instantiator visitArrayElement(ArrayElement node) {
-    throw 'Should not get here'; // Handled in visitArrayInitializer.
+  Instantiator visitArrayHole(ArrayHole node) {
+    return (arguments) => new ArrayHole();
   }
 
   Instantiator visitObjectInitializer(ObjectInitializer node) {
     List<Instantiator> propertyMakers =
         node.properties.map(visitSplayable).toList();
     bool isOneLiner = node.isOneLiner;
     return (arguments) {
       List<Property> properties = <Property>[];
       for (Instantiator instantiator in propertyMakers) {
         var result = instantiator(arguments);
@@ skipping 46 matching lines @@
     return null;
   }
 
   visitInterpolatedNode(InterpolatedNode node) {
     interpolatedNodes.add(node);
     containsInterpolatedNode.add(node);
     if (node.isNamed) holeNames.add(node.nameOrPosition);
     ++count;
   }
 }