Remove js.ArrayElement.

pkg/compiler/lib/src/js/printer.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js;
 
 class Printer extends Indentation implements NodeVisitor {
   final bool shouldCompressOutput;
   leg.Compiler compiler;
   leg.CodeBuffer outBuffer;
@@ skipping 756 matching lines @@
     }
     out(node.value);
   }
 
   visitLiteralNull(LiteralNull node) {
     out("null");
   }
 
   visitArrayInitializer(ArrayInitializer node) {
     out("[");
-    List<ArrayElement> elements = node.elements;
+    List<Expression> elements = node.elements;
     int elementIndex = 0;
-    for (int i = 0; i < node.length; i++) {
-      if (elementIndex < elements.length &&
-          elements[elementIndex].index == i) {
-        visitNestedExpression(elements[elementIndex].value, ASSIGNMENT,
-                              newInForInit: false, newAtStatementBegin: false);
-        elementIndex++;
-        // We can avoid a trailing "," if there was an element just before. So
-        // `[1]` and `[1,]` are the same, but `[,]` and `[]` are not.
-        if (i != node.length - 1) {
-          out(",");
-          spaceOut();
-        }
-      } else {
+    for (int i = 0; i < elements.length; i++) {
+      visitNestedExpression(elements[i], ASSIGNMENT,
+                            newInForInit: false, newAtStatementBegin: false);
+      // We can avoid a trailing "," if there was an element just before. So
+      // `[1]` and `[1,]` are the same, but `[,]` and `[]` are not.
+      if (i != elements.length - 1 ||
+          (i == 0 && elements[i] is ArrayHole)) {

[floitsch, 2014/11/28 12:42:50]

Why the check for "i == 0" ?

I think it should be:

for (int i = 0 ... ) {
  Expression element = elements[i];
  if (element is ArrayHole) {
    // Note that array holes must have a trailing "," even if they are
    // in last position. Otherwise `[,]` (having length 1) would become
    // equal to `[]` (the empty array).
    out(",");
    continue;
  }
  if (i != 0) spaceOut();
  visitNestedExpression(entry, ...);
  // We can skip the trailing "," for the last element (since it's not
  // an array hole).
  if (i != node.length - 1) out(",");
}

[sigurdm, 2014/11/28 14:52:11]

Yes, something was wrong in my logic. Thanks.
Adding a test for the array-hole case.

         out(",");
+        spaceOut();

[floitsch, 2014/11/28 12:42:50]

This means that we now have "[, ]" instead of "[,]".

[sigurdm, 2014/11/28 14:52:11]

True
Fixed

       }
     }
     out("]");
   }
 
-  visitArrayElement(ArrayElement node) {
-    throw "Unreachable";
+  visitArrayHole(ArrayHole node) {

[floitsch, 2014/11/28 12:42:50]

Should be unreachable again, if you use my code.

[sigurdm, 2014/11/28 14:52:11]

Done.

+    // An array hole is represented by the empty string.
   }
 
   visitObjectInitializer(ObjectInitializer node) {
     // Print all the properties on one line until we see a function-valued
     // property.  Ideally, we would use a proper pretty-printer to make the
     // decision based on layout.
     List<Property> properties = node.properties;
     out("{");
     indentMore();
     for (int i = 0; i < properties.length; i++) {
@@ skipping 358 matching lines @@
         codes.add(nthLetter((n ~/ nameSpaceSize) % LETTERS));
       }
       codes.add(charCodes.$0 + digit);
       newName = new String.fromCharCodes(codes);
     }
     assert(new RegExp(r'[a-zA-Z][a-zA-Z0-9]*').hasMatch(newName));
     maps.last[oldName] = newName;
     return newName;
   }
 }