Remove js.ArrayElement.

pkg/compiler/lib/src/js/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js;
 
 abstract class NodeVisitor<T> {
   T visitProgram(Program node);
 
   T visitBlock(Block node);
@@ skipping 37 matching lines @@
 
   T visitNamedFunction(NamedFunction node);
   T visitFun(Fun node);
 
   T visitLiteralBool(LiteralBool node);
   T visitLiteralString(LiteralString node);
   T visitLiteralNumber(LiteralNumber node);
   T visitLiteralNull(LiteralNull node);
 
   T visitArrayInitializer(ArrayInitializer node);
-  T visitArrayElement(ArrayElement node);
+  T visitArrayHole(ArrayHole node);
   T visitObjectInitializer(ObjectInitializer node);
   T visitProperty(Property node);
   T visitRegExpLiteral(RegExpLiteral node);
 
   T visitComment(Comment node);
 
   T visitInterpolatedExpression(InterpolatedExpression node);
   T visitInterpolatedLiteral(InterpolatedLiteral node);
   T visitInterpolatedParameter(InterpolatedParameter node);
   T visitInterpolatedSelector(InterpolatedSelector node);
@@ skipping 69 matching lines @@
   T visitFun(Fun node) => visitExpression(node);
 
   T visitLiteral(Literal node) => visitExpression(node);
 
   T visitLiteralBool(LiteralBool node) => visitLiteral(node);
   T visitLiteralString(LiteralString node) => visitLiteral(node);
   T visitLiteralNumber(LiteralNumber node) => visitLiteral(node);
   T visitLiteralNull(LiteralNull node) => visitLiteral(node);
 
   T visitArrayInitializer(ArrayInitializer node) => visitExpression(node);
-  T visitArrayElement(ArrayElement node) => visitNode(node);
+  T visitArrayHole(ArrayHole node) => visitExpression(node);
   T visitObjectInitializer(ObjectInitializer node) => visitExpression(node);
   T visitProperty(Property node) => visitNode(node);
   T visitRegExpLiteral(RegExpLiteral node) => visitExpression(node);
 
   T visitInterpolatedNode(InterpolatedNode node) => visitNode(node);
 
   T visitInterpolatedExpression(InterpolatedExpression node)
       => visitInterpolatedNode(node);
   T visitInterpolatedLiteral(InterpolatedLiteral node)
       => visitInterpolatedNode(node);
@@ skipping 768 matching lines @@
 class LiteralNumber extends Literal {
   final String value;
 
   LiteralNumber(this.value);
 
   accept(NodeVisitor visitor) => visitor.visitLiteralNumber(this);
   LiteralNumber _clone() => new LiteralNumber(value);
 }
 
 class ArrayInitializer extends Expression {
-  final int length;
-  // We represent the array as sparse list of elements. Each element knows its
-  // position in the array.
-  final List<ArrayElement> elements;
+  final List<Expression> elements;
 
-  ArrayInitializer(this.length, this.elements);
-
-  factory ArrayInitializer.from(Iterable<Expression> expressions) {
-    List<ArrayElement> elements = _convert(expressions);
-    return new ArrayInitializer(elements.length, elements);
-  }
+  ArrayInitializer(this.elements);
 
   accept(NodeVisitor visitor) => visitor.visitArrayInitializer(this);
 
   void visitChildren(NodeVisitor visitor) {
-    for (ArrayElement element in elements) element.accept(visitor);
+    for (Expression element in elements) element.accept(visitor);
   }
 
-  ArrayInitializer _clone() => new ArrayInitializer(length, elements);
+  ArrayInitializer _clone() => new ArrayInitializer(elements);
 
   int get precedenceLevel => PRIMARY;
-
-  static List<ArrayElement> _convert(Iterable<Expression> expressions) {
-    int index = 0;
-    return expressions.map(
-        (expression) => new ArrayElement(index++, expression))
-        .toList();
-  }
 }
 
 /**
- * An expression inside an [ArrayInitializer]. An [ArrayElement] knows
- * its position in the containing [ArrayInitializer].
+ * An empty place in an [ArrayInitializer].
+ * For example the list [1, , , 2] would contain two holes.
  */
-class ArrayElement extends Node {
-  final int index;
-  final Expression value;
+class ArrayHole extends Expression {
+  accept(NodeVisitor visitor) => visitor.visitArrayHole(this);
 
-  ArrayElement(this.index, this.value);
+  void visitChildren(NodeVisitor visitor) {}
 
-  accept(NodeVisitor visitor) => visitor.visitArrayElement(this);
+  ArrayHole _clone() => new ArrayHole();
 
-  void visitChildren(NodeVisitor visitor) {
-    value.accept(visitor);
-  }
-
-  ArrayElement _clone() => new ArrayElement(index, value);
+  int get precedenceLevel => PRIMARY;
 }
 
 class ObjectInitializer extends Expression {
   final List<Property> properties;
   final bool isOneLiner;
 
   /**
    * Constructs a new object-initializer containing the given [properties].
    *
    * [isOneLiner] describes the behaviour when pretty-printing (non-minified).
@@ skipping 126 matching lines @@
 class Comment extends Statement {
   final String comment;
 
   Comment(this.comment);
 
   accept(NodeVisitor visitor) => visitor.visitComment(this);
   Comment _clone() => new Comment(comment);
 
   void visitChildren(NodeVisitor visitor) {}
 }