Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(29)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chromeos/test/data/network/user.onc
Issue
750313003
:
ONC: Add IPConfigType. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@ipconfig_object
Patch Set: Change clearing of StaticIPConfig.
Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chromeos/network/onc/onc_normalizer.cc
chromeos/network/onc/onc_normalizer_unittest.cc
chromeos/network/onc/onc_signature.cc
chromeos/network/onc/onc_translator_onc_to_shill.cc
chromeos/network/onc/onc_validator.cc
chromeos/test/data/network/augmented_merge.json
chromeos/test/data/network/device_policy.onc
chromeos/test/data/network/managed_toplevel1.onc
chromeos/test/data/network/settings_with_normalization.json
chromeos/test/data/network/toplevel_wifi_open.onc
chromeos/test/data/network/user.onc
components/onc/docs/onc_spec.html
components/onc/onc_constants.h
components/onc/onc_constants.cc
View unified diff
|
Download patch
« no previous file with comments
|
« chromeos/test/data/network/toplevel_wifi_open.onc
('k') |
components/onc/docs/onc_spec.html »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 { "Type": "Ethernet",
1 { "Type": "Ethernet",
2 "Name": "testopenvpn",
2 "Name": "testopenvpn",
3 "VPN": {
3 "VPN": {
4 "Host": "users host",
4 "Host": "users host",
5 "Type": "OpenVPN",
5 "Type": "OpenVPN",
6 "OpenVPN": {
6 "OpenVPN": {
7 "Port": 1195,
7 "Port": 1195,
8 "Password": "users password"
8 "Password": "users password"
9 }
9 }
10 },
10 },
11 "ProxySettings": {
11 "ProxySettings": {
12 "Type": "Direct"
12 "Type": "Direct"
13 },
13 },
14
"IPConfigType": "Static",
14 "StaticIPConfig": {
15 "StaticIPConfig": {
15 "Type": "IPv4",
16 "Type": "IPv4",
16 "IPAddress": "1.2.3.4",
17 "IPAddress": "1.2.3.4",
17 "SearchDomains": [ "acme.org" ]
18 "SearchDomains": [ "acme.org" ]
18 }
19 }
19 }
20 }
OLD
NEW
« no previous file with comments
|
« chromeos/test/data/network/toplevel_wifi_open.onc
('k') |
components/onc/docs/onc_spec.html »
('j') |
no next file with comments »
Issue 750313003: ONC: Add IPConfigType. (Closed)
Created 6 years ago by pneubeck (no reviews)
Modified 5 years, 11 months ago
Reviewers: stevenjb
Base URL: https://chromium.googlesource.com/chromium/src.git@ipconfig_object
Comments: 8
This is Rietveld
408576698
Chromium Code Reviews
Issue 750313003:
ONC: Add IPConfigType. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@ipconfig_object