Fix implicit scoped_refptr<T> to T* conversion in TestMetroViewerProcessHost

ash/test/test_metro_viewer_process_host.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/test/test_metro_viewer_process_host.h"
 
 #include <windef.h>
 
 #include "base/logging.h"
 #include "ui/aura/remote_window_tree_host_win.h"
 #include "ui/gfx/win/dpi.h"
 
 namespace ash {
 namespace test {
 
 TestMetroViewerProcessHost::TestMetroViewerProcessHost(
-    base::SingleThreadTaskRunner* ipc_task_runner)
-    : MetroViewerProcessHost(ipc_task_runner),
-      closed_unexpectedly_(false) {
+    const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner)
+    : MetroViewerProcessHost(ipc_task_runner), closed_unexpectedly_(false) {

[Daniel Erat, 2014/11/24 18:53:55]

nit: back to one per line since they don't all fit on the same line as the
signature

(does clang-format still do this? :-( )

[dcheng, 2014/11/24 19:02:36]

Yes. I'd prefer not to fight clang-format, because that means I'll have to keep
fighting clang-format in every patch that ever touches this code.

I don't think this is actually against the style guide:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Constructor_I...
states that "[c]onstructor initializer lists can be all on one line". It does
not mention anything about the initializer list having to be on the same line as
all the parameters. I see no Chromium-specific style guidelines that would apply
in this situation.

[Nico, 2014/11/24 19:05:22]

I think clang-format used to do one-per-line-or-all-on-one-line, and then
pkasting decreed that that isn't correct and clang-format changed in response to
that, see: https://code.google.com/p/chromium/issues/detail?id=430111

So I think this is working as intended.

 }
 
 TestMetroViewerProcessHost::~TestMetroViewerProcessHost() {
 }
 
 void TestMetroViewerProcessHost::TerminateViewer() {
   base::ProcessId viewer_process_id = GetViewerProcessId();
   if (viewer_process_id != base::kNullProcessId) {
     base::ProcessHandle viewer_process = NULL;
     base::OpenProcessHandleWithAccess(
@@ skipping 29 matching lines @@
 void TestMetroViewerProcessHost::OnHandleSearchRequest(
     const base::string16& search_string) {
 }
 
 void TestMetroViewerProcessHost::OnWindowSizeChanged(uint32 width,
                                                      uint32 height) {
 }
 
 }  // namespace test
 }  // namespace ash