Fix the failure to fail in PlatformCanvasWin ctor...

Fix the failure to fail in PlatformCanvasWin ctor

For a renderer CrashForBitmapAllocationFailure does not crash in any of the 4 CHECKS(), it
crashes calling GetProcessMemoryInfo()
- Because GetProcessMemoryInfo() tries to load PSAPI.dll and the sandbox blocks it.
- Now it gives a better dump by disabling the iniling of the function
- Adds a check for the shared memory, which I suspect is the real cause for some of the crashes


BUG=10585
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13872

[amit, 2009-04-16 15:12:08]

Nice, lgtm.

http://codereview.chromium.org/75027/diff/1/2
File skia/ext/platform_canvas_win.cc (right):

http://codereview.chromium.org/75027/diff/1/2#newcode53
Line 53: CHECK(::CloseHandle(shared_section) == TRUE);
Since we don't own the handle, isn't it better to use say GetHandleInformation
to check validity? It's probably not a strong argument since we are going to
crash anyway :)

[cpu_(ooo_6.6-7.5), 2009-04-16 18:28:55]

http://codereview.chromium.org/75027/diff/1/2
File skia/ext/platform_canvas_win.cc (right):

http://codereview.chromium.org/75027/diff/1/2#newcode53
Line 53: CHECK(::CloseHandle(shared_section) == TRUE);
On 2009/04/16 15:12:09, amit wrote:
> Since we don't own the handle, isn't it better to use say GetHandleInformation
> to check validity? It's probably not a strong argument since we are going to
> crash anyway :)

Done.

[cpu_(ooo_6.6-7.5), 2009-04-24 05:10:40]

LGTM