Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 750203003: Suppress additional multipicturedraw GM for Android (Closed)

Created:
6 years ago by robertphillips
Modified:
6 years ago
Reviewers:
Tom Hudson, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Suppress additional multipicturedraw GM for Android One Android bot is failing on the rect test case. TBR=tomhudson@google.com NOTRY=true NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/6247fa0ba081d816643ee24b3f51a3f58e0477bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robertphillips
6 years ago (2014-11-24 18:55:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750203003/1
6 years ago (2014-11-24 18:56:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/6247fa0ba081d816643ee24b3f51a3f58e0477bf
6 years ago (2014-11-24 18:56:24 UTC) #5
Tom Hudson
I'd like to understand: is this really a bug but sufficiently non-critical that you'll work ...
6 years ago (2014-11-24 18:57:12 UTC) #7
robertphillips
6 years ago (2014-11-24 19:04:00 UTC) #8
Message was sent while issue was closed.
On 2014/11/24 18:57:12, Tom Hudson wrote:
> I'd like to understand: is this really a bug but sufficiently non-critical
that
> you'll work around it later?

From running on my local machine I expected image differences in the Sierpinski
and rrect_clip multipicturedraw GMs but forgot to put them in the
ignored-tests.txt file in the initial CL.

I did not expect that the rect_clip case to have any image differences but (from
looking at it) it is just a BW rasterization difference between the hoisted and
non-hoisted paths.

I will rebaseline all these tomorrow once all the bots finish.

Powered by Google App Engine
This is Rietveld 408576698