Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 750183005: Un-deprecate Element.setAttributeNodeNS() (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
Mike West
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

Un-deprecate Element.setAttributeNodeNS() It is back in the DOM Standard: https://dom.spec.whatwg.org/#dom-element-setattributenodens After discussion in a spec bug it seems best to leave it be: https://www.w3.org/Bugs/Public/show_bug.cgi?id=27344 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185940

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition11-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodegettextcontent08-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodelookupnamespaceuri16-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodelookupprefix16-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/dom/xhtml/level3/core/nodesettextcontent06-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/lang-mapped-to-webkit-locale-dynamic-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Element/attr-param-typechecking-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Element/missing-arguments-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/xss-DENIED-iframe-src-alias-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
test
6 years ago (2014-11-25 09:48:44 UTC) #1
philipj_slow
PTAL
6 years ago (2014-11-25 09:49:02 UTC) #3
Mike West
LGTM.
6 years ago (2014-11-25 10:30:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750183005/20001
6 years ago (2014-11-25 10:33:11 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-25 11:09:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185940

Powered by Google App Engine
This is Rietveld 408576698