Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: chrome/browser/chromeos/net/network_portal_notification_controller.h

Issue 750153002: ChromeOS: bypass proxy for captive portal authorization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/net/network_portal_notification_controller.h
diff --git a/chrome/browser/chromeos/net/network_portal_notification_controller.h b/chrome/browser/chromeos/net/network_portal_notification_controller.h
index 3b825d41ace5afee005bc791c9e1c29eeabb44f0..221eaf03489d16f3ec5bec1ab2c73627095c1ab9 100644
--- a/chrome/browser/chromeos/net/network_portal_notification_controller.h
+++ b/chrome/browser/chromeos/net/network_portal_notification_controller.h
@@ -13,8 +13,10 @@
namespace chromeos {
class NetworkState;
+class NetworkPortalWebDialog;
-class NetworkPortalNotificationController {
+class NetworkPortalNotificationController
+ : public base::SupportsWeakPtr<NetworkPortalNotificationController> {
public:
// The values of these metrics are being used for UMA gathering, so it is
// important that they don't change between releases.
@@ -47,10 +49,16 @@ class NetworkPortalNotificationController {
const NetworkState* network,
const NetworkPortalDetector::CaptivePortalState& state);
+ // Creates NetworkPortalWebDialog.
+ void ShowDialog();
+ void OnDialogDestroyed(const NetworkPortalWebDialog* dialog);
ygorshenin1 2014/11/24 15:02:09 nit: insert a blank line between these two methods
Alexander Alekseev 2014/11/26 00:26:28 Done.
+
private:
// Last network path for which notification was displayed.
std::string last_network_path_;
+ NetworkPortalWebDialog* dialog_;
+
DISALLOW_COPY_AND_ASSIGN(NetworkPortalNotificationController);
};

Powered by Google App Engine
This is Rietveld 408576698