Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: pkg/analyzer/lib/source/pub_package_map_provider.dart

Issue 750113003: null check for pub result in PubPackageMapProvider (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/source/pub_package_map_provider.dart
diff --git a/pkg/analyzer/lib/source/pub_package_map_provider.dart b/pkg/analyzer/lib/source/pub_package_map_provider.dart
index c0d34316d114f0d9af9731b02cdb689737b9a74f..a45fc9065dbbb92bef5c220bf511f8a3bf29642e 100644
--- a/pkg/analyzer/lib/source/pub_package_map_provider.dart
+++ b/pkg/analyzer/lib/source/pub_package_map_provider.dart
@@ -56,8 +56,10 @@ class PubPackageMapProvider implements PackageMapProvider {
"Error running pub $PUB_LIST_COMMAND\n$exception\n$stackTrace");
}
if (result == null || result.exitCode != 0) {
+ String exitCode =
+ result != null ? 'exit code ${result.exitCode}' : 'null';
AnalysisEngine.instance.logger.logInformation(
- "pub $PUB_LIST_COMMAND failed: exit code ${result.exitCode}");
+ "pub $PUB_LIST_COMMAND failed: $exitCode");
return _error(folder);
}
try {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698