[Telemetry] Fix sudoers file parsing

[Telemetry] Fix sudoers file parsing

Fix the regex we use for parsing the sudoers file to allow arguments after the binary path.

BUG=423688
Committed: https://crrev.com/fe5b98e23b5cfd2bce79edc7a92069fbbe3b9fe6
Cr-Commit-Position: refs/heads/master@{#306839}

[jeremy, 2014-12-04 15:49:08]

jeremy@chromium.org changed reviewers:
+ skyostil@google.com

[Sami, 2014-12-04 15:57:00]

skyostil@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2014-12-04 15:57:01]

https://codereview.chromium.org/750093007/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/platform/posix_platform_backend.py (right):

https://codereview.chromium.org/750093007/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/posix_platform_backend.py:20: if
re.match(r'\s*\(.+\) NOPASSWD: %s(\s\S+)*$' % path, line):
re.escape(path) would be a little safer.

https://codereview.chromium.org/750093007/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/posix_platform_backend.py:23: 
nit: add an extra blank line here.

https://codereview.chromium.org/750093007/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/posix_platform_backend.py:25: """Returns
True if the binary at |path| appears explicitly in the sudoers
nit: The first line of a docstring generally should be short enough to not need
wrapping. If you need more detail, add them in a separate section after a blank
line.

[Sami, 2014-12-04 15:57:26]

Thanks for adding the test btw.

[jeremy, 2014-12-04 16:03:15]

All fixed, ready for another look.

https://codereview.chromium.org/750093007/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/platform/posix_platform_backend.py (right):

https://codereview.chromium.org/750093007/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/posix_platform_backend.py:20: if
re.match(r'\s*\(.+\) NOPASSWD: %s(\s\S+)*$' % path, line):
On 2014/12/04 15:57:00, Sami wrote:
> re.escape(path) would be a little safer.

Done.

https://codereview.chromium.org/750093007/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/posix_platform_backend.py:23: 
On 2014/12/04 15:57:00, Sami wrote:
> nit: add an extra blank line here.

Done.

https://codereview.chromium.org/750093007/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/platform/posix_platform_backend.py:25: """Returns
True if the binary at |path| appears explicitly in the sudoers
On 2014/12/04 15:57:00, Sami wrote:
> nit: The first line of a docstring generally should be short enough to not
need
> wrapping. If you need more detail, add them in a separate section after a
blank
> line.

Done.

[Sami, 2014-12-04 16:05:50]

lgtm with an indentation tweak.

https://codereview.chromium.org/750093007/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/platform/posix_platform_backend.py (right):

https://codereview.chromium.org/750093007/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/platform/posix_platform_backend.py:17: """Returns
True if the binary in |path| features in the sudoers file.
Indent -= 2 for these two functions.

[jeremy, 2014-12-04 16:08:22]

The CQ bit was checked by jeremy@chromium.org

[commit-bot: I haz the power, 2014-12-04 16:08:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/750093007/40001

[commit-bot: I haz the power, 2014-12-04 17:08:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-04 17:09:02]

Patchset 3 (id:??) landed as
https://crrev.com/fe5b98e23b5cfd2bce79edc7a92069fbbe3b9fe6
Cr-Commit-Position: refs/heads/master@{#306839}