Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 750093005: Fix unititialized read. (Closed)

Created:
6 years ago by eustas
Modified:
6 years ago
Reviewers:
groby-ooo-7-16, jam
CC:
chromium-reviews, darin-cc_chromium.org, glider+watch_chromium.org, jam, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix unititialized read. Initialize recenly added member in RequestInfo. BUG=436977 TBR=jam@chromium.org Committed: https://crrev.com/5be0aad09d4350d6b8d5ccd7280dd7c021ff547b Cr-Commit-Position: refs/heads/master@{#306569}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M content/child/request_info.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/valgrind/drmemory/suppressions.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
eustas
6 years ago (2014-12-01 06:57:48 UTC) #2
eustas
6 years ago (2014-12-01 06:59:59 UTC) #4
groby-ooo-7-16
https://codereview.chromium.org/750093005/diff/1/content/child/npapi/plugin_url_fetcher.cc File content/child/npapi/plugin_url_fetcher.cc (right): https://codereview.chromium.org/750093005/diff/1/content/child/npapi/plugin_url_fetcher.cc#newcode119 content/child/npapi/plugin_url_fetcher.cc:119: request_info.should_reset_appcache = false; Please do set a default value ...
6 years ago (2014-12-01 17:51:10 UTC) #5
eustas
https://codereview.chromium.org/750093005/diff/1/content/child/npapi/plugin_url_fetcher.cc File content/child/npapi/plugin_url_fetcher.cc (right): https://codereview.chromium.org/750093005/diff/1/content/child/npapi/plugin_url_fetcher.cc#newcode119 content/child/npapi/plugin_url_fetcher.cc:119: request_info.should_reset_appcache = false; On 2014/12/01 17:51:10, groby wrote: > ...
6 years ago (2014-12-02 07:06:02 UTC) #6
groby-ooo-7-16
LGTM
6 years ago (2014-12-02 17:19:19 UTC) #7
jam
lgtm
6 years ago (2014-12-02 20:53:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750093005/20001
6 years ago (2014-12-03 05:50:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-03 07:29:18 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-03 07:31:16 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5be0aad09d4350d6b8d5ccd7280dd7c021ff547b
Cr-Commit-Position: refs/heads/master@{#306569}

Powered by Google App Engine
This is Rietveld 408576698