Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 750063002: Remove implicit conversions from scoped_refptr to T* in base/ (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
CC:
chromium-reviews, erikwright+watch_chromium.org, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in base/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Windows build. BUG=110610 Committed: https://crrev.com/f3c56d51dac268caa4186b27eb3f738ce85b8d20 Cr-Commit-Position: refs/heads/master@{#305277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M base/test/test_shortcut_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/win/shortcut.cc View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 1 month ago (2014-11-21 17:28:11 UTC) #2
rvargas (doing something else)
lgtm
6 years, 1 month ago (2014-11-21 18:59:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/750063002/1
6 years, 1 month ago (2014-11-21 19:13:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-21 21:01:56 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 21:02:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3c56d51dac268caa4186b27eb3f738ce85b8d20
Cr-Commit-Position: refs/heads/master@{#305277}

Powered by Google App Engine
This is Rietveld 408576698