Add a getter for system url request context in CastBrowserContext.

Add a getter for system url request context in CastBrowserContext.

Committed: https://crrev.com/a5186bd0261ed5cb131e65198617e3a7c5bd5bcc
Cr-Commit-Position: refs/heads/master@{#305239}

[lcwu1, 2014-11-21 02:40:02]

lcwu@chromium.org changed reviewers:
+ byungchul@chromium.org, gunsch@chromium.org

[lcwu1, 2014-11-21 02:46:16]

lcwu@chromium.org changed reviewers:
+ dougsteed@chromium.org

[gunsch, 2014-11-21 03:52:17]

Why in CastBrowserContext, as opposed to, say, CastBrowserProcess?

[lcwu1, 2014-11-21 05:50:25]

On 2014/11/21 03:52:17, gunsch wrote:
> Why in CastBrowserContext, as opposed to, say, CastBrowserProcess?

CastBrowserContext already has similar functions to retrieve main/media request
context getter, so it is consistent to have the system url request context
getter in there as well. Also it makes more sense (semantically) to get the url
request context from the browser context object instead of from the
CastBrowserProcess which is simply a holder that owns several top-level browser
data structures.

[gunsch, 2014-11-21 15:13:15]

LGTM
On Nov 20, 2014 9:50 PM, <lcwu@chromium.org> wrote:

> On 2014/11/21 03:52:17, gunsch wrote:
>
>> Why in CastBrowserContext, as opposed to, say, CastBrowserProcess?
>>
>
> CastBrowserContext already has similar functions to retrieve main/media
> request
> context getter, so it is consistent to have the system url request context
> getter in there as well. Also it makes more sense (semantically) to get
> the url
> request context from the browser context object instead of from the
> CastBrowserProcess which is simply a holder that owns several top-level
> browser
> data structures.
>
> https://codereview.chromium.org/749833002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[gunsch, 2014-11-21 15:41:28]

lgtm

[lcwu1, 2014-11-21 17:22:36]

The CQ bit was checked by lcwu@chromium.org

[commit-bot: I haz the power, 2014-11-21 17:23:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/749833002/1

[commit-bot: I haz the power, 2014-11-21 18:03:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-21 18:04:04]

Patchset 1 (id:??) landed as
https://crrev.com/a5186bd0261ed5cb131e65198617e3a7c5bd5bcc
Cr-Commit-Position: refs/heads/master@{#305239}