Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 749793002: Data reduction proxy bypass with test server (Closed)

Created:
6 years, 1 month ago by bengr
Modified:
6 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Data reduction proxy bypass with test server Include tests that verify the interaction of the data reduction proxy's bypass mechanism and a real server. BUG=438866 Committed: https://crrev.com/c913531c74e525174cff7df56fc8e683c2abd3ca Cr-Commit-Position: refs/heads/master@{#307982}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Addressed comments from mmenke #

Total comments: 2

Patch Set 3 : Addressed nit #

Patch Set 4 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -3 lines) Patch
M components/components_unittests.isolate View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc View 2 chunks +121 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params_test_utils.cc View 1 chunk +9 lines, -0 lines 0 comments Download
A + components/test/data/data_reduction_proxy/OWNERS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + components/test/data/data_reduction_proxy/direct/block10.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/data_reduction_proxy/direct/block10.html.mock-http-headers View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/test/data/data_reduction_proxy/direct/noblock.html View 1 chunk +1 line, -0 lines 0 comments Download
A + components/test/data/data_reduction_proxy/direct/noblock.html.mock-http-headers View 1 chunk +1 line, -0 lines 0 comments Download
A components/test/data/data_reduction_proxy/proxy/block10.html View 1 chunk +1 line, -0 lines 0 comments Download
A components/test/data/data_reduction_proxy/proxy/block10.html.mock-http-headers View 1 chunk +5 lines, -0 lines 0 comments Download
A + components/test/data/data_reduction_proxy/proxy/noblock.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/test/data/data_reduction_proxy/proxy/noblock.html.mock-http-headers View 1 chunk +1 line, -0 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 1 2 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
bengr
marq: components/* mmenke: net/*
6 years ago (2014-12-04 00:36:17 UTC) #5
mmenke
https://codereview.chromium.org/749793002/diff/60001/net/test/embedded_test_server/embedded_test_server.cc File net/test/embedded_test_server/embedded_test_server.cc (right): https://codereview.chromium.org/749793002/diff/60001/net/test/embedded_test_server/embedded_test_server.cc#newcode55 net/test/embedded_test_server/embedded_test_server.cc:55: if (request_path.find("http://127.0.0.1") == 0) { Can you just create ...
6 years ago (2014-12-04 18:17:09 UTC) #6
bengr
https://codereview.chromium.org/749793002/diff/60001/net/test/embedded_test_server/embedded_test_server.cc File net/test/embedded_test_server/embedded_test_server.cc (right): https://codereview.chromium.org/749793002/diff/60001/net/test/embedded_test_server/embedded_test_server.cc#newcode55 net/test/embedded_test_server/embedded_test_server.cc:55: if (request_path.find("http://127.0.0.1") == 0) { On 2014/12/04 18:17:08, mmenke ...
6 years ago (2014-12-05 23:13:32 UTC) #7
marq (ping after 24h)
lgtm
6 years ago (2014-12-05 23:26:35 UTC) #8
mmenke
net/ LGTM https://chromiumcodereview.appspot.com/749793002/diff/80001/net/test/embedded_test_server/embedded_test_server.cc File net/test/embedded_test_server/embedded_test_server.cc (right): https://chromiumcodereview.appspot.com/749793002/diff/80001/net/test/embedded_test_server/embedded_test_server.cc#newcode55 net/test/embedded_test_server/embedded_test_server.cc:55: if (GURL(relative_url).is_valid()) nit: Should create the GURL ...
6 years ago (2014-12-08 18:16:05 UTC) #9
bengr
https://chromiumcodereview.appspot.com/749793002/diff/80001/net/test/embedded_test_server/embedded_test_server.cc File net/test/embedded_test_server/embedded_test_server.cc (right): https://chromiumcodereview.appspot.com/749793002/diff/80001/net/test/embedded_test_server/embedded_test_server.cc#newcode55 net/test/embedded_test_server/embedded_test_server.cc:55: if (GURL(relative_url).is_valid()) On 2014/12/08 18:16:05, mmenke wrote: > nit: ...
6 years ago (2014-12-08 22:29:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749793002/100001
6 years ago (2014-12-08 22:57:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/28967)
6 years ago (2014-12-08 23:04:17 UTC) #14
bengr
@blundell: components/test/* and components/components_unittests.isolate
6 years ago (2014-12-09 21:01:39 UTC) #16
blundell
lgtm assuming satisfactory answer to the below question Why can't the tests run on iOS? ...
6 years ago (2014-12-10 15:50:05 UTC) #17
bengr
On 2014/12/10 15:50:05, blundell wrote: > lgtm assuming satisfactory answer to the below question > ...
6 years ago (2014-12-11 19:53:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749793002/120001
6 years ago (2014-12-11 20:47:52 UTC) #20
commit-bot: I haz the power
6 years ago (2014-12-11 23:08:53 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c913531c74e525174cff7df56fc8e683c2abd3ca
Cr-Commit-Position: refs/heads/master@{#307982}

Powered by Google App Engine
This is Rietveld 408576698