Mac Lion: Chrome opens new window on restart when no windows were previously open

Mac Lion: Chrome opens new window on restart when no windows were previously open

Changes startup / restore behavior to better match Lion resume expectations.  Chrome can get launched by the |loginwindow| process due to the resume feature on Lion.  In this case, if there were no windows open in Chrome when restarting, Chrome re-opens with no windows upon login.  This is also the expectation under previous OSs when Chrome is a login item, so that's been changed here too.

BUG=90249
TEST=Manual.  On Lion.  Turn Chrome session restore on, close all windows (but don't quit), restart computer.  Expect Chrome launches on startup with no open windows.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96198

[Robert Sesek, 2011-08-10 15:06:49]

Mark may be a better reviewer because he can approve the base/mac/ changes.

[Mark Mentovai, 2011-08-10 15:53:02]

LGTM

Note that <AppKit/NSApplication.h> has


/* The following key is present in the userInfo of
NSApplicationDidFinishLaunchingNotification.  Its value is an NSNumber
containing a bool.  It will be NO if the app was launched to open or print a
file, to perform a Service, if the app had saved state that will be restored, or
if the app launch was in some other sense not a "default" launch.  Otherwise its
value will be YES.
 */
APPKIT_EXTERN NSString * const NSApplicationLaunchIsDefaultLaunchKey
NS_AVAILABLE_MAC(10_7);

but NSApplicationDidFinishLaunchingNotification probably comes too late for us,
and we’d need to figure out whether this does anything differently than the
login-item detection.

http://codereview.chromium.org/7497056/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/7497056/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:920: if
(base::mac::WasLaunchedAsLoginOrResumeItem())
Use {braces} around the multi-line job.

[dhollowa, 2011-08-10 16:16:57]

Yes, using NSApplicationLaunchIsDefaultLaunchKey was my first, most hopeful,
choice.  Sadly this doesn't do what one would hope it would.  The value remained
|NO| in every flavor of launch that I tried: double-click, doc, restart, etc.
etc.  I'll file a radar bug on this.

http://codereview.chromium.org/7497056/diff/1/chrome/browser/ui/browser_init.cc
File chrome/browser/ui/browser_init.cc (right):

http://codereview.chromium.org/7497056/diff/1/chrome/browser/ui/browser_init....
chrome/browser/ui/browser_init.cc:920: if
(base::mac::WasLaunchedAsLoginOrResumeItem())
On 2011/08/10 15:53:02, Mark Mentovai wrote:
> Use {braces} around the multi-line job.

Done.

[Mark Mentovai, 2011-08-10 16:18:15]

LGTM