Issue 749693002: Add base::mac::ScopedMachPortSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 749693002: Add base::mac::ScopedMachPortSet (Closed)

Created:
6 years, 1 month ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Add base::mac::ScopedMachPortSet. Contrary to its documentation, kqueue()'s EVFILT_MACHPORT doesn't work with raw Mach receive rights, it only works with port sets. It's easy enough to add a receive right to a port set, but we should have a scoper to dispose of the port set. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/34497e9a4083ca4c47ea50d715d4d7fe9c375aa7

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	base/mac/scoped_mach_port.h	View		2 chunks	+21 lines, -0 lines	0 comments	Download
	M	base/mac/scoped_mach_port.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/34497e9a4083ca4c47ea50d715d4d7fe9c375aa7 Cr-Commit-Position: refs/heads/master@{#305228}

6 years, 1 month ago (2014-11-21 16:53:04 UTC) #4

Mark Mentovai

6 years, 1 month ago (2014-11-21 16:53:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
34497e9a4083ca4c47ea50d715d4d7fe9c375aa7 (presubmit successful).