Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: Source/core/html/HTMLCanvasElement.h

Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase to ToT Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLCanvasElement.h
diff --git a/Source/core/html/HTMLCanvasElement.h b/Source/core/html/HTMLCanvasElement.h
index feddebbe1f98272481b54b6ce5f78f9333edb9ea..c0e1f56bd9ecfb5a661d50dba3a2ccc11ef1662b 100644
--- a/Source/core/html/HTMLCanvasElement.h
+++ b/Source/core/html/HTMLCanvasElement.h
@@ -119,9 +119,9 @@ public:
void ensureUnacceleratedImageBuffer();
ImageBuffer* buffer() const;
- Image* copiedImage() const;
+ enum SourceBuffer { Front, Back };
Ken Russell (switch to Gerrit) 2014/11/26 00:49:10 There are now three copies of this enum. Could you
dshwang 2014/11/26 13:37:29 Nice suggestion. I thought it's not pretty but I d
+ Image* copiedImage(SourceBuffer) const;
void clearCopiedImage();
- PassRefPtrWillBeRawPtr<ImageData> getImageData() const;
SecurityOrigin* securityOrigin() const;
bool originClean() const { return m_originClean; }
@@ -187,7 +187,7 @@ private:
void updateExternallyAllocatedMemory() const;
- String toDataURLInternal(const String& mimeType, const double* quality, bool isSaving = false) const;
+ String toDataURLInternal(const String& mimeType, const double* quality, SourceBuffer) const;
WillBeHeapHashSet<RawPtrWillBeWeakMember<CanvasObserver>> m_observers;

Powered by Google App Engine
This is Rietveld 408576698