Source/core/html/HTMLCanvasElement.h - Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCanvasElement.h

Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix bot failure, and fix existing bug of HTMLCanvasElement::imageSourceURL() Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLCanvasElement.h

diff --git a/Source/core/html/HTMLCanvasElement.h b/Source/core/html/HTMLCanvasElement.h

index 9e695d7d668a5f19d56671b33b8dc6c745988400..d155dba46aa651eb400b046e0813b4b29bd10b26 100644

--- a/Source/core/html/HTMLCanvasElement.h

+++ b/Source/core/html/HTMLCanvasElement.h

@@ -119,9 +119,9 @@ public:

void ensureUnacceleratedImageBuffer();

ImageBuffer* buffer() const;

- Image* copiedImage() const;

+ enum SourceBuffer { Front, Back };

+ Image* copiedImage(SourceBuffer) const;

void clearCopiedImage();

- PassRefPtrWillBeRawPtr<ImageData> getImageData() const;

SecurityOrigin* securityOrigin() const;

bool originClean() const { return m_originClean; }

@@ -188,7 +188,7 @@ private:

void updateExternallyAllocatedMemory() const;

- String toDataURLInternal(const String& mimeType, const double* quality, bool isSaving = false) const;

+ String toDataURLInternal(const String& mimeType, const double* quality, SourceBuffer) const;

WillBeHeapHashSet<RawPtrWillBeWeakMember<CanvasObserver>> m_observers;

« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/html/HTMLCanvasElement.cpp » ('j') | Source/core/html/HTMLCanvasElement.cpp » ('J')