Source/core/html/canvas/WebGLRenderingContextBase.h - Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.h

Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address nits Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/html/canvas/CanvasRenderingContext.h ('k') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('j') | Source/platform/graphics/gpu/DrawingBuffer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLRenderingContextBase.h

diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.h b/Source/core/html/canvas/WebGLRenderingContextBase.h

index aacb79cd6c3a67e2939b5f46b7e46cc549a284fe..16e31ccb0ddc2fa15082aaebbd0c989397ed3637 100644

--- a/Source/core/html/canvas/WebGLRenderingContextBase.h

+++ b/Source/core/html/canvas/WebGLRenderingContextBase.h

@@ -348,7 +348,7 @@ public:

void reshape(int width, int height);

void markLayerComposited();

- PassRefPtrWillBeRawPtr<ImageData> paintRenderingResultsToImageData();

+ PassRefPtrWillBeRawPtr<ImageData> paintRenderingResultsToImageData(SourceDrawingBuffer);

void removeSharedObject(WebGLSharedObject*);

void removeContextObject(WebGLContextObject*);

@@ -398,7 +398,7 @@ protected:

virtual bool is3d() const override { return true; }

virtual bool isAccelerated() const override { return true; }

virtual void setIsHidden(bool) override;

- virtual void paintRenderingResultsToCanvas(SourceBuffer) override;

+ virtual void paintRenderingResultsToCanvas(SourceDrawingBuffer) override;

virtual blink::WebLayer* platformLayer() const override;

void addSharedObject(WebGLSharedObject*);