Source/core/frame/ImageBitmap.cpp - Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/ImageBitmap.cpp

Issue 749653002: WebGL: clarify which Front or Back buffer is used by each API. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address nits Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/ImageBitmap.cpp

diff --git a/Source/core/frame/ImageBitmap.cpp b/Source/core/frame/ImageBitmap.cpp

index d5ffd02ca4d036e88de2d5672443ed8e2a25739e..50290cbbeced454f1e425d3d0bf3966b3e73ba75 100644

--- a/Source/core/frame/ImageBitmap.cpp

+++ b/Source/core/frame/ImageBitmap.cpp

@@ -82,7 +82,7 @@ ImageBitmap::ImageBitmap(HTMLCanvasElement* canvas, const IntRect& cropRect)

{

CanvasRenderingContext* sourceContext = canvas->renderingContext();

if (sourceContext && sourceContext->is3d())

- sourceContext->paintRenderingResultsToCanvas(CanvasRenderingContext::Back);

+ sourceContext->paintRenderingResultsToCanvas(BackBuffer);

IntRect srcRect = intersection(cropRect, IntRect(IntPoint(), canvas->size()));

m_bitmapRect = IntRect(IntPoint(std::max(0, -cropRect.x()), std::max(0, -cropRect.y())), srcRect.size());

« no previous file with comments | « Source/core/editing/Editor.cpp ('k') | Source/core/html/HTMLCanvasElement.h » ('j') | Source/platform/graphics/gpu/DrawingBuffer.cpp » ('J')