src/x64/full-codegen-x64.cc - Issue 749633002: harmony-scoping: make assignment to 'const' a late error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/full-codegen-x64.cc

Issue 749633002: harmony-scoping: make assignment to 'const' a late error. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/full-codegen-x64.cc

diff --git a/src/x64/full-codegen-x64.cc b/src/x64/full-codegen-x64.cc

index ac31cfda545d0bd8e80ac8627056cf2e14d92f81..92937d59f62c4e2169e98abc0062d178dc550beb 100644

--- a/src/x64/full-codegen-x64.cc

+++ b/src/x64/full-codegen-x64.cc

@@ -2596,8 +2596,9 @@ void FullCodeGenerator::EmitVariableAssignment(Variable* var,

}

EmitStoreToStackLocalOrContextSlot(var, location);

}

+ } else if (var->IsSignallingAssignmentToConst(op, strict_mode())) {

+ __ CallRuntime(Runtime::kThrowConstAssignError, 0);

}

- // Non-initializing assignments to consts are ignored.

}