Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 749563002: easy-unlock: Do not show icon for online auth type. (Closed)

Created:
6 years, 1 month ago by xiyuan
Modified:
6 years, 1 month ago
Reviewers:
tbarzic
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

easy-unlock: Do not show icon for online auth type. BUG=433912 Committed: https://crrev.com/efe4158e426e1ddc7bfc7ba948b9ca6beaa4573a Cr-Commit-Position: refs/heads/master@{#305106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/signin/easy_unlock_screenlock_state_handler.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xiyuan
6 years, 1 month ago (2014-11-20 19:55:53 UTC) #2
tbarzic
lgtm
6 years, 1 month ago (2014-11-20 22:06:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/749563002/1
6 years, 1 month ago (2014-11-20 22:09:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 23:10:54 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 23:12:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efe4158e426e1ddc7bfc7ba948b9ca6beaa4573a
Cr-Commit-Position: refs/heads/master@{#305106}

Powered by Google App Engine
This is Rietveld 408576698