Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 74953005: Fix https://code.google.com/p/dart/issues/detail?id=15132, by not doing load elimination on typed a… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (revision 30337)
+++ sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (working copy)
@@ -1649,6 +1649,9 @@
void visitIndexAssign(HIndexAssign instruction) {
HInstruction receiver = instruction.receiver.nonCheck();
+ JavaScriptBackend backend = compiler.backend;
+ // Typed arrays may narrow incoming values.
+ if (backend.couldBeTypedArray(receiver.instructionType)) return;
memorySet.registerKeyedValueUpdate(
receiver, instruction.index, instruction.value);
}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/backend.dart ('k') | tests/lib/typed_data/typed_data_load_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698